-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email not send after upgrade to Magento 2.3.3 #25338
Comments
Hi @Thomas-gt3. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @Thomas-gt3 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
@Thomas-gt3 there was included backward incompatible change. Please apply the patch listed in release notes for fixing it |
Thanks, I download patch on my server and when I run it it does not find the files yet I paste the file path :
|
Try to use `patch -p1` Instead of `patch`
…On Tue, 29 Oct 2019 at 13:56, Thomas-gt3 ***@***.***> wrote:
Thanks, I download patch on my server and when I run it it does not find
the files yet I paste the file path :
$ cd httpdocs/
$ ls
app cgi-bin composer.lock dev generated img lib nginx.conf.sample pub test vendor
auth.json.sample CHANGELOG.md COPYING.txt EmailMessageInterface_2.3.3_backward_compatibility_github-2019-10-14-03-45-36.patch grunt-config.json.sample index.html LICENSE_AFL.txt package.json.sample SECURITY.md update
bin composer.json css favicon.ico Gruntfile.js.sample index.php LICENSE.txt phpserver setup var
$ patch <EmailMessageInterface_2.3.3_backward_compatibility_github-2019-10-14-03-45-36.patch
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/app/code/Magento/Email/Model/Transport.php b/app/code/Magento/Email/Model/Transport.php
|index cbce1682cb5..79ceb56a883 100644
|--- a/app/code/Magento/Email/Model/Transport.php
|+++ b/app/code/Magento/Email/Model/Transport.php
--------------------------
File to patch: /app/code/Magento/Email/Model/Transport.php
/app/code/Magento/Email/Model/Transport.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 32
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php b/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
|index 32f12dada57..4210312c55a 100644
|--- a/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
|+++ b/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
--------------------------
File to patch: /dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php
/dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 45
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/dev/tests/integration/testsuite/Magento/Framework/Mail/EmailMessageTest.php b/dev/tests/integration/testsuite/Magento/Framework/Mail/EmailMessageTest.php
|index 10a54b4e1b8..186c3e2796c 100644
|--- a/dev/tests/integration/testsuite/Magento/Framework/Mail/EmailMessageTest.php
|+++ b/dev/tests/integration/testsuite/Magento/Framework/Mail/EmailMessageTest.php
--------------------------
File to patch: /dev/tests/integration/testsuite/Magento/Framework/Mail/EmailMessageTest.php
/dev/tests/integration/testsuite/Magento/Framework/Mail/EmailMessageTest.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
3 out of 3 hunks ignored
can't find file to patch at input line 114
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/lib/internal/Magento/Framework/Mail/EmailMessage.php b/lib/internal/Magento/Framework/Mail/EmailMessage.php
|index aaef9750751..02c75977cd0 100644
|--- a/lib/internal/Magento/Framework/Mail/EmailMessage.php
|+++ b/lib/internal/Magento/Framework/Mail/EmailMessage.php
--------------------------
File to patch: /lib/internal/Magento/Framework/Mail/EmailMessage.php
/lib/internal/Magento/Framework/Mail/EmailMessage.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
13 out of 13 hunks ignored
can't find file to patch at input line 308
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/lib/internal/Magento/Framework/Mail/EmailMessageInterface.php b/lib/internal/Magento/Framework/Mail/EmailMessageInterface.php
|index 95f83ff679c..93eaa4acde3 100644
|--- a/lib/internal/Magento/Framework/Mail/EmailMessageInterface.php
|+++ b/lib/internal/Magento/Framework/Mail/EmailMessageInterface.php
--------------------------
File to patch: /lib/internal/Magento/Framework/Mail/EmailMessageInterface.php
/lib/internal/Magento/Framework/Mail/EmailMessageInterface.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 338
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/lib/internal/Magento/Framework/Mail/MailMessageInterface.php b/lib/internal/Magento/Framework/Mail/MailMessageInterface.php
|index da010be2702..5179e6057c4 100644
|--- a/lib/internal/Magento/Framework/Mail/MailMessageInterface.php
|+++ b/lib/internal/Magento/Framework/Mail/MailMessageInterface.php
--------------------------
File to patch: /lib/internal/Magento/Framework/Mail/MailMessageInterface.php
/lib/internal/Magento/Framework/Mail/MailMessageInterface.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 351
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/lib/internal/Magento/Framework/Mail/Message.php b/lib/internal/Magento/Framework/Mail/Message.php
|index b15b75ca9ac..1f423e80108 100644
|--- a/lib/internal/Magento/Framework/Mail/Message.php
|+++ b/lib/internal/Magento/Framework/Mail/Message.php
--------------------------
File to patch: /lib/internal/Magento/Framework/Mail/Message.php
/lib/internal/Magento/Framework/Mail/Message.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 373
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php b/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
|index 4a8d6572faa..2d28e2f560a 100644
|--- a/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
|+++ b/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
--------------------------
File to patch: /lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php
/lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php: No such file or directory
Skip this patch? [y] y
Skipping patch.
1 out of 1 hunk ignored
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25338?email_source=notifications&email_token=AAOJOUMYF3GWY37XTM5DDOTQRAQHDA5CNFSM4JGBTVZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQG43Q#issuecomment-547384942>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOJOUKF6EWBVA7G6OIURTLQRAQHDANCNFSM4JGBTVZQ>
.
|
Result is identical :
|
@Thomas-gt3 had the same issue. The problem was due to special characters being used in the sender/receiver name. In my case I was using special characters for my sales e-mail name. |
@Thomas-gt3 Upload the patch files into magento_root/patches |
Hi @engcom-Delta. Thank you for working on this issue.
|
Problem persists and now when I send email there is a blank page.
|
I restored backup and I think I will wait update Magento 2.3.4 |
A white page typically means that there is some PHP error which you can find in your logfiles. Does this occur on the current develop branch too? |
Hi @Thomas-gt3 thank you for your report. I am not able to reproduce issue by upgrading from 2.2 to 2.3-develop git version and from 2.2.10 to 2.3.3(latest release). If you'd like to update the issue, please reopen it. |
I suspect the issue behaves differently depending on the platform being used. Mail is not being sent as described by the submitter (from the order review screen and when an order is placed). In tracking this down: It is related to the "-f" argument that is sent to sendmail via PHP. Magento supplies 'john@example.com' to Zend Sendmail.php (with the quotes). if PHP php.ini mail setting is as below; `[mail function] then PHP expects -fjohn@example.com (without the quotes) or '-fjohn@example.com' with the quotes if PHP mail setting is as this; The Temp fix was to preg_replace() the -f in the $parameters of Sendmail.php before the mail() execute function . Effectively converting -f'john@example.com' to 'john@example.com' Quick Example Fix:
In summary, these formats 'john@example.com' , '-fjohn@example.com' and -f'john@example.com' apparently work on some platforms, but this Linux expects -fjohn@example.com or 'john@example.com' |
Hi, We have the same problem, and applying the patch + upgrading to 2.3.4 fixed email sending. However, the new account registration email is not being sent still. Any ideas? Thanks, |
Please open a new issue so we can check this in detail. |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: