-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ApiFunctional TestFramework GraphQL Client Parses Headers Improperly #26425
Comments
Hi @damienwebdev. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @damienwebdev do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
@engcom-Bravo Thank you for verifying the issue. Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:
Once all required information is added, please add label |
Hi @engcom-Bravo. Thank you for working on this issue.
|
@engcom-Bravo Thank you for verifying the issue. Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:
Once all required information is added, please add label |
✅ Confirmed by @engcom-Bravo Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hello @damienwebdev Thank you, for your report. Can you please create a pull request on this issue? Thank you for collaboration |
Hi @michalderlatka. Thank you for working on this issue.
|
Preconditions (*)
Magento v2.3.3
Steps to reproduce (*)
GraphQlAbstract::graphQlQueryWithResponseHeaders
Access-Control-Allow-Origin: https://www.example.com
Expected result (*)
['Access-Control-Allow-Origin'] => 'https://www.example.com'
Actual result (*)
See above.
This is due to a failed
preg_split
logic in:https://github.com/magento/magento2/blame/6b4a82b8554917ba78f7bc84ada8ea05a85aca92/dev/tests/api-functional/framework/Magento/TestFramework/TestCase/GraphQl/Client.php#L210
It should
preg_split
with a limit of2
:cc: @danielrenaud @danmooney2
The text was updated successfully, but these errors were encountered: