Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApiFunctional TestFramework GraphQL headers parsing #28915

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix ApiFunctional TestFramework GraphQL headers parsing #28915

merged 1 commit into from
Sep 2, 2020

Conversation

michalderlatka
Copy link
Contributor

Description (*)

Change how headers are parsed in ApiFunctional TestFramework so header values including urls are parsed properly

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [BUG] ApiFunctional TestFramework GraphQL Client Parses Headers Improperly #26425

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 29, 2020

Hi @michalderlatka. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Jun 29, 2020
@michalderlatka
Copy link
Contributor Author

@magento run all tests

@rogyar rogyar self-assigned this Jun 29, 2020
@rogyar rogyar added Award: bug fix Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Jun 29, 2020
@rogyar
Copy link
Contributor

rogyar commented Jun 29, 2020

@magento run Functional Tests B2B

2 similar comments
@michalderlatka
Copy link
Contributor Author

@magento run Functional Tests B2B

@michalderlatka
Copy link
Contributor Author

@magento run Functional Tests B2B

rogyar
rogyar approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in the functional tests is not related to the current change

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Jun 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7762 has been created to process this Pull Request

@nrkapoor nrkapoor assigned avattam06 and michalderlatka and unassigned rogyar and avattam06 Jul 14, 2020
@danielrenaud danielrenaud added Project: GraphQL PAP Partners acceleration program labels Jul 20, 2020
@ghost ghost assigned danielrenaud Jul 20, 2020
@danielrenaud danielrenaud moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 20, 2020
@danielrenaud danielrenaud moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Jul 20, 2020
@ghost ghost moved this from Merge in Progress to Ready for Testing in Pull Requests Dashboard Aug 31, 2020
@ghost ghost assigned cpartica and unassigned danielrenaud Aug 31, 2020
@cpartica cpartica moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Aug 31, 2020
@cpartica cpartica moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard Aug 31, 2020
magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2020
@cpartica
ENGCOM-7762: Fix ApiFunctional TestFramework GraphQL headers parsing #…
9880697 
…28915
@magento-engcom-team magento-engcom-team merged commit 2a4d4e8 into magento:2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @michalderlatka, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@cpartica cpartica cpartica approved these changes

@danielrenaud danielrenaud danielrenaud approved these changes

@prabhuram93 prabhuram93 Awaiting requested review from prabhuram93

Assignees

@michalderlatka michalderlatka

@cpartica cpartica

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix PAP Partners acceleration program Progress: accept Project: GraphQL Release Line: 2.4
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ApiFunctional TestFramework GraphQL Client Parses Headers Improperly
6 participants
@michalderlatka @rogyar @magento-engcom-team @cpartica @danielrenaud @avattam06