Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF: AdminAddingNewOptionsWithImagesAndPricesToConfigurableProductTest is failing in CI process #26610

Closed
lbajsarowicz opened this issue Jan 31, 2020 · 4 comments
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@lbajsarowicz
Copy link
Contributor

lbajsarowicz commented Jan 31, 2020

Summary (*)

When working with #26454 - I faced the failing test AdminAddingNewOptionsWithImagesAndPricesToConfigurableProductTest. Test outcome was completely unclear:
image

Also, ScreenShot wasn't helpful at all:
image

I started to investigate with adding full Exception message to the Notification:
image

As you see - it's trying to remove Product with ID = 5. But (!) the test hasn't created any Product with ID = 5:
image

So I got deeper - why it's actually trying to remove product ID = 5 and noticed that it's actually filtering product to remove:
image

... by product name that is empty!
image

That bug is caused by invalid handler introduced by Magento QA team and exists on other tests too - but by coincidence, the it's not overlapping with other test operating on the same data:

image

Examples (*)

Proposed solution

C'mon, fix it :-)

@lbajsarowicz lbajsarowicz added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jan 31, 2020
@magento-deployment-service
Copy link

Thanks for opening this issue!

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2020

Hi @lbajsarowicz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 31, 2020
lbajsarowicz added a commit to lbajsarowicz/magento2 that referenced this issue Jan 31, 2020
@magento-deployment-service
Copy link

Thanks for opening this issue!

@slavvka
Copy link
Member

slavvka commented Feb 8, 2020

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #26611 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 8, 2020
@slavvka slavvka closed this as completed Feb 8, 2020
magento-engcom-team added a commit that referenced this issue Feb 8, 2020
…6611

 - Merge Pull Request #26611 from lbajsarowicz/magento2:hotfix/26610-ci-failure
 - Merged commits:
   1. b29cdcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

3 participants