Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26610 Fix failing CI due to invalid variable handler #26611

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jan 31, 2020

Description (*)

Filtering by Product Name was impossible due to the use of a non-existing variable that threw warning to console output during running test. Unfortunately - the warning was ignored and the whole test was passing by coincidence (no other test running simultaneously).

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. MFTF: AdminAddingNewOptionsWithImagesAndPricesToConfigurableProductTest is failing in CI process #26610

Manual testing scenarios (*)

  1. Modify README.md file
  2. Submit PR to Github

Questions or comments

🤦‍♂️

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run Functional Tests EE

@ihor-sviziev ihor-sviziev self-assigned this Jan 31, 2020
@lbajsarowicz
Copy link
Contributor Author

@magento run Functional Tests CE

@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 4, 2020
@ihor-sviziev
Copy link
Contributor

Failing functional test is not related to changes from this PR

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6795 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 5, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
Maybe today 🙏

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants