Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport resizing on search input focus on iphone #27506

Closed
Zyles opened this issue Mar 30, 2020 · 6 comments
Closed

Viewport resizing on search input focus on iphone #27506

Zyles opened this issue Mar 30, 2020 · 6 comments
Assignees
@ptylek
Labels
Area: Frontend Component: Search Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Zyles
Copy link

Zyles commented Mar 30, 2020

When you click the search input box the viewport changes size and the layout breaks using iphone and luma theme.

Preconditions (*)

  1. Magento 2.3.3
  2. Luma theme
  3. Iphone / Safari

Steps to reproduce (*)

  1. Navigate to luma demo with iphone and safari
  2. Click search icon
  3. Click search input

Expected result (*)

Should not resize the view and cause sidescrolling.

Actual result (*)

Resizes view and causes sidescrolling.
@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @Zyles. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Zyles do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog Mar 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 30, 2020
@krishprakash krishprakash self-assigned this Mar 31, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2020 •
edited by krishprakash
Loading

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Area: Frontend Component: Search Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Apr 3, 2020
@ghost ghost unassigned krishprakash Apr 3, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Apr 3, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 3, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-33050 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ptylek ptylek self-assigned this Apr 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @ptylek. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Apr 4, 2020
ptylek added a commit to ptylek/magento2 that referenced this issue Apr 4, 2020
@ptylek
magento#27506 Fix zoom on search input
0d1d42c
@ptylek ptylek mentioned this issue Apr 4, 2020
Merged
4 tasks
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Apr 4, 2020
magento-engcom-team added a commit that referenced this issue Apr 16, 2020
@magento-engcom-team
ENGCOM-7289: Fix zoom on search input #27506 #27603
ebe7aec 
 - Merge Pull Request #27603 from ptylek/magento2:fix-zoom_search_input
 - Merged commits:
   1. 0d1d42c
magento-engcom-team pushed a commit that referenced this issue Apr 16, 2020
@slavvka
ENGCOM-7289: Fix zoom on search input #27506 #27603
0553adf
magento-engcom-team added a commit that referenced this issue Apr 16, 2020
@magento-engcom-team
🔃 [Magento Community Engineering] Community Contributions - 2.4-devel…
e5ea17f 
…op latest changes

Accepted Community Pull Requests:
 - #27603: Fix zoom on search input #27506 (by @ptylek)
 - #27689: [MFTF] Using action group to go to admin category page (by @Usik2203)
 - #27685: Removed a duplicate variable in Magento\QuoteGraphQl\Model\Resolver\Cart and in \Magento\QuoteGraphQl\Model\Resolver\SetBillingAddressOnCart (by @bgorski)
 - #27677: [MFTF] Removed redundant ActionGroup (by @Usik2203)
 - #27325: MFTF: Fix failing CMS tests due to PageBuilder conflict (by @lbajsarowicz)
 - #27701: #27638 Fix fatal errors in Unit Tests (by @lbajsarowicz)
@sdzhepa
Copy link
Contributor

sdzhepa commented Apr 30, 2020

The Issue has been fixed and delivered with #27603

@sdzhepa sdzhepa closed this as completed Apr 30, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Apr 30, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @Zyles. Thank you for your report.
The issue has been fixed in #27603 by @ptylek in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team removed this from Done (last 30 days) in Community Backlog May 1, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.3 Indicates original Magento version for the Issue report. label Nov 13, 2020
This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptylek ptylek

Labels
Area: Frontend Component: Search Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Zyles @sdzhepa @magento-engcom-team @ptylek @krishprakash