-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate plugins for ActionInterface in Framework #28050
Comments
Hi @buskamuza. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @buskamuza do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @lbajsarowicz. Thank you for working on this issue.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions. |
There are still Plugins in Framework namespace. |
Hi @engcom-Delta. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Delta Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @engcom-Golf. Thank you for working on this issue.
|
Summary (*)
Magento 2.4-develop
Eliminate plugins for
\Magento\Framework\App\ActionInterface
underlib/internal/Magento/Framework/App/Action/Plugin
Reason: plugins should be used to customize behavior of one module from another module. In this case, plugins that belong to Framework customize class behavior of the same Framework.
Examples (*)
The problem is in the code and execution flow being more complex than it could be.
Proposed solution
It is suggested to add desired behavior directly to the place where it's expected to execute. Consider
\Magento\Framework\App\FrontController::dispatch()
part of the framework as the place to inject necessary behavior.The text was updated successfully, but these errors were encountered: