Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#28050 Get rid of ActionInterface plugins #28170

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented May 8, 2020

Description (*)

Response for #28050 request.

Related Pull Requests

Fixed Issues (if relevant)

  1. fixes Eliminate plugins for ActionInterface in Framework #28050

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@lbajsarowicz
Copy link
Contributor Author

The integration tests were performed by calling dispatch on Action.
That is not going to work without decision about further steps.

On hold for now 🤦

@ihor-sviziev
Copy link
Contributor

FYI this PR was moved to "oh hold" due to internal discussions, reason the same as there #27538 (comment)

buskamuza
buskamuza previously approved these changes May 19, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev reopened this May 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 20, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev
Copy link
Contributor

Sorry, just clicked wrong button. Re-opened

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbajsarowicz please review and fix failing tests

@ghost ghost dismissed buskamuza’s stale review May 20, 2020 07:49

Pull Request state was updated. Re-review required.

@ihor-sviziev
Copy link
Contributor

@lbajsarowicz,
Will you be able to update your PR?

@lbajsarowicz
Copy link
Contributor Author

Yes

@lbajsarowicz
Copy link
Contributor Author

@ihor-sviziev I'll try to finish that during the upcoming weekend.

@ihor-sviziev ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jun 22, 2020
@ihor-sviziev
Copy link
Contributor

@lbajsarowicz will you continue working on this PR? 🐈

@ihor-sviziev
Copy link
Contributor

@lbajsarowicz I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@m2-assistant
Copy link

m2-assistant bot commented Jul 7, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: App Component: Store Component: Theme Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate plugins for ActionInterface in Framework
4 participants