Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save product in store view scope without Magento_Catalog::edit_product_design ACL #28106

Closed
kassner opened this issue May 5, 2020 · 25 comments
Labels
Component: Admin Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@kassner
Copy link
Contributor

kassner commented May 5, 2020

Preconditions

  1. Magento Open Source 2.4-develop from GitHub (6b6f428);
  2. Default installation without sample data;
  3. A second website+store+store view is configured;

Steps to reproduce

  1. Under System > Permissions > User Roles, create a new role with the entire Catalog tree selected, except for Catalog > Inventory > Products > Edit Product Design;

  1. Create a user assigned to this new role and log into the backend with it;
  2. Add a simple product with title test 1. Under Products in Websites, select both websites. Save the product;
  3. Still in the product edit form, change the scope to the second store view;
  4. Under the Design tab, check that you are indeed not allowed to change the attributes (fields are disabled):

Screenshot from 2020-05-05 11-43-57

  1. For the Name field, uncheck the Use Default Value option and give it a new name (i.e.: test 2);
  2. Save the product;

Expected result

  1. The new name was saved for the selected store view;

Actual result

  1. Not allowed to edit the product's design attributes error.

Screenshot from 2020-05-05 11-49-12

The same happens for other fields, like product name or description.

Additional information

@m2-assistant
Copy link

m2-assistant bot commented May 5, 2020

Hi @kassner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@kassner do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog May 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 5, 2020
@swathishs swathishs self-assigned this May 6, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 6, 2020

Hi @swathishs. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@swathishs
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @swathishs, here is your Magento instance.
Admin access: https://i-28106-2-4-develop.instances.magento-community.engineering/admin_2aea
Login: 30a5c8a3 Password: bac7e7f897aa
Instance will be terminated in up to 3 hours.

@swathishs
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @swathishs. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @swathishs, here is your Magento instance.
Admin access: https://i-28106-2-4-develop.instances.magento-community.engineering/admin_548b
Login: 9b911112 Password: 764e194d422a
Instance will be terminated in up to 3 hours.

@swathishs
Copy link

I'm unable to reproduce this issue on the 2.4-develop instance.

Please find the attachments for reference

Configured second website :
image

New product:
image

Viedo for reference:
https://drive.google.com/file/d/19y5y2T54RzOkPGb99soQ_nohq90dxB3p/view?usp=sharing

@swathishs swathishs added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch and removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels May 7, 2020
@kassner
Copy link
Contributor Author

kassner commented May 7, 2020

@swathishs Your user still has permissions to Edit Product Design. All fields in the Design tab should be disabled but in your video they aren't.

@kassner
Copy link
Contributor Author

kassner commented May 7, 2020

@swathishs this is how the role should look like

Screenshot from 2020-05-07 15-38-00

@swathishs
Copy link

@kassner Okay I will try with this role and let you know

@swathishs
Copy link

@kassner: As per the role which you have suggested I have tired the issue is reproducible in 2.4-develop instance

Attachments:
image

image

image

@swathishs swathishs added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels May 7, 2020
@magento-engcom-team
Copy link
Contributor

@swathishs Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 7, 2020
@ghost ghost unassigned swathishs May 7, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog May 7, 2020
@ghost ghost moved this from Ready for Dev to Ready for QA in Community Backlog May 7, 2020
@swathishs swathishs self-assigned this May 8, 2020
@sdzhepa sdzhepa moved this from Ready for Development to Pull Request In Progress in High Priority Backlog Oct 23, 2020
@ghost ghost moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Oct 23, 2020
@sdzhepa sdzhepa moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 23, 2020
@ghost ghost moved this from Dev In Progress to Ready for Development in High Priority Backlog Oct 23, 2020
@ghost ghost moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 23, 2020
@ghost ghost moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Oct 23, 2020
@ghost ghost moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Oct 23, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 23, 2020

@kassner

The issue was closed by mistake.
at this moment Magento team has fixed it, internal PR is ready(CR and QA passed) but not merged into the main code-base.
As soon as it will be merged related commits can be found using search based on internal ticket key MC-34156
Example: https://github.com/magento/magento2/search?q=MC-34156&type=commits

Sorry for inconvenience

@zakdma
Copy link
Contributor

zakdma commented Nov 4, 2020

Internal ticket MC-34156 merged into mainline

@sdzhepa sdzhepa added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 5, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Nov 5, 2020

The related internal Jira ticket MC-34156 was closed as Fixed.
Related commits can be found by search https://github.com/magento/magento2/search?q=MC-34156&type=commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

No branches or pull requests

6 participants