Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting correct label value of yes or no (Boolean) type attribute in aggregations data of products GraphQl response #29123

Closed
1 of 5 tasks
prabhakaran777 opened this issue Jul 14, 2020 · 10 comments · May be fixed by #31876
Closed
1 of 5 tasks
Assignees
Labels
Area: Framework Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed PAP Partners acceleration program Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@prabhakaran777
Copy link

prabhakaran777 commented Jul 14, 2020

Preconditions (*)

1.Magento 2.3.4 and 2.4-develop
2.Product attribute Yes or No (Boolean)

Steps to reproduce (*)

1.Product attribute Yes or No (Boolean)
2.Create product with Yes or No attribute
3.Run Product query with aggregations

Expected result (*)

  1. Expected Result with aggregation that attribute label

{
"attribute_code": "yes_no",
"label": "Yes or no",
"options": [
{
"count": 1,
"label": "No", //here label with yes or no
"value": "0"
}
]
2.

Actual result (*)

  1. [Screenshots, logs or description]
    Label has showing same as value
    Screenshot from 2020-07-14 09-52-50

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Additional info from Engcom

Used the following query

query {
  products(search: "Product2", pageSize: 25) {
    aggregations {
      attribute_code
      label
      options {
        count
        label
        value
      }
    }
  }
}

response

{
  "data": {
    "products": {
      "aggregations": [
        {
          "attribute_code": "price",
          "label": "Price",
          "options": [
            {
              "count": 1,
              "label": "10-20",
              "value": "10_20"
            }
          ]
        },
        {
          "attribute_code": "yes_no",
          "label": "Yes or No",
          "options": [
            {
              "count": 1,
              "label": "0", #<<<< label No if No is selected as value
              "value": "0"
            }
          ]
        }
      ]
    }
  }
}
@m2-assistant
Copy link

m2-assistant bot commented Jul 14, 2020

Hi @prabhakaran777. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Ready for QA in Community Backlog Jul 14, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 14, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 21, 2020
@ghost ghost removed this from Ready for QA in Community Backlog Oct 21, 2020
@ghost ghost removed this from Ready for Grooming in Low Priority Backlog Oct 21, 2020
@ghost ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 21, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
@engcom-Bravo engcom-Bravo self-assigned this Jan 26, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 26, 2021

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Jan 26, 2021

Hello @prabhakaran777

Thank you for your report.

Yes, it would probably make more sense if the label returned Yes or No instead of 1 or 0
We Confirm the issue is reproducible on 2.4-develop and move it to GraphQL team.
Additional info is added to the description.

@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 26, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jan 26, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-40629 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-assistant
Copy link

m2-assistant bot commented Jan 27, 2021

Hi @sasha19957099. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in GraphQL Backlog Jan 27, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in GraphQL Backlog Jan 28, 2021
sasha19957099 added a commit to sasha19957099/magento2 that referenced this issue Jan 28, 2021
…type attribute in aggregations data of products GraphQl response - fixed static tests
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 18, 2021
@magento-engcom-team magento-engcom-team added this to Pull Request In Progress in High Priority Backlog Nov 8, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in GraphQL Backlog Nov 8, 2021
@engcom-Alfa engcom-Alfa added Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 9, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7920 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2023

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@glo05363
Copy link
Contributor

It will be taken care into one of the Internal JIRA ticket. Once Internal PR will get merged, we will notify.

Thank you!

@engcom-November
Copy link
Contributor

Hi @prabhakaran777 ,
Development is currently working on this issue.
Thank you.

@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog Apr 18, 2023
@m2-community-project m2-community-project bot removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Apr 18, 2023
@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Apr 18, 2023

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-7920 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-7920&type=commits

Based on the Jira ticket, the target version is 2.4.7-beta1.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed PAP Partners acceleration program Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
10 participants