Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29123 not getting correct label value of yes or no type attribute in aggregations data of products graphql response #31876

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

sasha19957099
Copy link
Contributor

@sasha19957099 sasha19957099 commented Jan 28, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Not getting correct label value of yes or no (Boolean) type attribute in aggregations data of products GraphQl response #29123

Manual testing scenarios (*)

1.Product attribute Yes or No (Boolean)
2.Create product with Yes or No attribute
3.Run Product query with aggregations

query {
products(search: "Sample Simple Product", pageSize: 25) {
items{
sku
}
aggregations {
attribute_code
label
options {
count
label
value
}
}
}
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…type attribute in aggregations data of products GraphQl response - fixed label
…type attribute in aggregations data of products GraphQl response - test coverage
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2021

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sasha19957099
Copy link
Contributor Author

@magento run all tests

…type attribute in aggregations data of products GraphQl response - fixed static tests
@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099
Copy link
Contributor Author

@magento run Functional Tests EE

1 similar comment
@sasha19957099
Copy link
Contributor Author

@magento run Functional Tests EE

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 18, 2021
@glo05363
Copy link
Contributor

@sasha19957099 Thank you fixing this issue.

It will be taken care into one of the Internal JIRA ticket. Once Internal PR will get merged, we will notify.

Thank you!

@engcom-November
Copy link
Contributor

Development team is currently working on this issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogGraphQl PAP Partners acceleration program Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review Project: GraphQL Release Line: 2.4
Projects
Status: Pending Review
7 participants