Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Edit Issue when there is a newsletter queue associated with it. #30645

Closed
chichitsai0517 opened this issue Oct 24, 2020 · 15 comments · Fixed by #30727
Closed

Customer Edit Issue when there is a newsletter queue associated with it. #30645

chichitsai0517 opened this issue Oct 24, 2020 · 15 comments · Fixed by #30727
Assignees
Labels
Component: Newsletter Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.

Comments

@chichitsai0517
Copy link

chichitsai0517 commented Oct 24, 2020

Preconditions (*)

Installed a fresh copy of Magento 2.3.5-P2 with no sample data. Upgrade using composer to 2.4 (where we see the issue) and then upgrade to 2.4.1 (where issue is still present).

  1. I tried on 2.4.0 and 2.4.1 and they both have the same issue.
  2. Reproducible on 2.4-develop

Steps to reproduce (*)

  1. Add a new customer which is also subscribed to newsletter.
  2. Create a a newsletter in Marketing>Newsletter Templates
  3. Queue the newsletter
  4. Go to customer and try to edit their information - This is what we get (https://prnt.sc/v642qm)
  5. Go create a new customer and subscribe to newsletter (however this new customer is not and has not been in any newsletter queue yet) - When we go and edit this customer, everything is ok (https://prnt.sc/v64460).

Expected result (*)

  1. See Screenshot (https://prnt.sc/v64460)

Actual result (*)

  1. See Screenshot (https://prnt.sc/v642qm)
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @chichitsai0517. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mohanelamurugan
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @mohanelamurugan. Thank you for your request. I'm working on Magento instance for you.

@mohanelamurugan
Copy link

Unable to reproduce this issue, Works fine on both 2.4 and 2.4.1

Steps followed:

  • Create a new customer with newsletter subscription.
  • Create a newsletter and queue it.
  • Edit the customer created.

@engcom-Bravo engcom-Bravo self-assigned this Oct 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hello @chichitsai0517

Thank you for your report

We confirm that we are able to reproduce the issue on 2.4.1
Repro

However, it is already fixed on 2.4-develop, and will be delivered in the next release
develop

So we are closing this issue. Please feel free to comment, reopen or create new ticket according to the Issue reporting guidelines

Thank you

@engcom-Bravo engcom-Bravo added the not-confirmed Use for Issue that was closed during confirmation label Oct 26, 2020
@engcom-Bravo engcom-Bravo reopened this Oct 26, 2020
@engcom-Bravo
Copy link
Contributor

Let's leave this issue opened until the 2.4-develop and 2.4.1 are synchronized

@chichitsai0517
Copy link
Author

Is there a temporary solution to fix this until the next release?

@engcom-Bravo engcom-Bravo removed the not-confirmed Use for Issue that was closed during confirmation label Oct 26, 2020
@ioweb-gr
Copy link
Contributor

It would be very helpful to know which commits fix it so that we can apply the patch on our crippled instances.

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Oct 29, 2020

After the 2.4-develop and 2.4.1 synchronization, the issue is reproducible on 2.4-develop also.
We confirm the issue and move it to Ready for Development

@engcom-Bravo engcom-Bravo added Component: Newsletter Component: Ui Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 29, 2020
@ghost ghost removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: ready for confirmation labels Oct 29, 2020
@sdzhepa sdzhepa added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Oct 29, 2020
@engcom-Golf engcom-Golf self-assigned this Oct 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2020

Hi @engcom-Golf. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost added Progress: PR in progress and removed Progress: dev in progress Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Oct 30, 2020
@engcom-Golf engcom-Golf added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 2, 2020
@fedekrum
Copy link

fedekrum commented Nov 4, 2020

Is there a temporary solution to fix this until the next release?

Yes, there is if you don't care about the newsletter's queue. Erase it in the database by truncating newsletter_queue and problem solved.

@engcom-Bravo
Copy link
Contributor

Is there a temporary solution to fix this until the next release?

#30727

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Newsletter Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants