[MFTF] Coverage for the 30645 Customer Edit Issue when there is a newsletter queue associated with it

[AnnaAPak]

Description (*)

The test covers the 30645 Customer Edit Issue when there is a newsletter queue associated with it

Related Pull Requests

PR 30727

Manual testing scenarios (*)

1. Create a customer
2. Create a newsletter template
3. Queue the newsletter template
4. Update customer information

[m2-assistant]

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[AnnaAPak]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[rogyar]

Hi @AnnaAPak. Thank you for providing this useful refactoring.
Please, check my comments below.

Thanks

[rogyar]

Please, fix the indentation

Suggested change

	<description>Extends AdminMarketingCreateNewsletterTemplateActionGroup.
	Clicks the Show/Hide button for the Template Content field before text is sent to this field</description>
	<description>
	Extends AdminMarketingCreateNewsletterTemplateActionGroup. Clicks the Show/Hide button for the Template Content field before text is sent to this field
	</description>

[engcom-Hotel]

Has been fixed.

[rogyar]

Let me shed some additional light using this example.
In HTML/XHTML/XML the most commonly used practices in terms of such indentations are the following.

If the opening and closing tags are in the same line, we may put content between these tags.

<tag>Content</tag>

If we want to split lines, the common practice is to have the opening and closing tags in dedicated lines.

<tag>
    Some long long long long content
</tag>

So having

<tag> Some long long long long 
    and even more long content
</tag>

Is not a common practice.

I hope this example makes sense.

Thank you!

[engcom-Hotel]

Has been fixed.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests CE, Static Tests, WebAPI Tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-8823 has been created to process this Pull Request

[engcom-Alfa]

QA not applicable

[m2-assistant]

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.