Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #31040

Closed
3 of 4 tasks
m2-assistant bot opened this issue Nov 24, 2020 · 3 comments · Fixed by #30959
Closed
3 of 4 tasks

[Issue] Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #31040

m2-assistant bot opened this issue Nov 24, 2020 · 3 comments · Fixed by #30959
Assignees
Labels
Component: Directory Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2020

This issue is automatically created based on existing pull request: #30959: Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden


Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Install Magento
  2. Check table directory_country_region for Albania,Denmark,Greece,Iceland,Portugal and Sweden states/regions.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Directory Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 24, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 2, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-39545 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@cptX
Copy link

cptX commented May 4, 2023

The Greek regions are wrongly written with special characters that are never used nor in Greece neither in english translations of the greek regions. Why is that?

For example this is the data stored in the database (I think the above commits are responsible for this)

        ['GR', 'GR-A', 'Anatolikí Makedonía kai Thráki'],
        ['GR', 'GR-I', 'Attikí'],
        ['GR', 'GR-G', 'Dytikí Elláda'],
        ['GR', 'GR-C', 'Dytikí Makedonía'],
        ['GR', 'GR-F', 'Ionía Nísia'],
        ['GR', 'GR-D', 'Ípeiros'],
        ['GR', 'GR-B', 'Kentrikí Makedonía'],
        ['GR', 'GR-M', 'Kríti'],
        ['GR', 'GR-L', 'Nótio Aigaío'],
        ['GR', 'GR-J', 'Pelopónnisos'],
        ['GR', 'GR-H', 'Stereá Elláda'],
        ['GR', 'GR-E', 'Thessalía'],
        ['GR', 'GR-K', 'Vóreio Aigaío'],
        
        For example the first line is

['GR', 'GR-A', 'Anatolikí Makedonía kai Thráki'], but should be
['GR', 'GR-A', 'Anatoliki Makedonia kai Thraki'],

the same for second line
['GR', 'GR-I', 'Attikí'] should be
['GR', 'GR-I', 'Attiki'] (last char changed to ascii 'i')

There is absolutely no reason to not use Ascii characters here...

Can somebody explain why these special chars are included and make our lives much more difficult? Nobody uses these characters in Greece!!

Here are the corrected ones:

    ['GR', 'GR-A', 'Anatoliki Makedonia kai Thraki'],
    ['GR', 'GR-I', 'Attiki'],
    ['GR', 'GR-G', 'Dytiki Ellada'],
    ['GR', 'GR-C', 'Dytiki Makedonia'],
    ['GR', 'GR-F', 'Ionia Nisia'],
    ['GR', 'GR-D', 'Ipeiros'],
    ['GR', 'GR-B', 'Kentriki Makedonia'],
    ['GR', 'GR-M', 'Kriti'],
    ['GR', 'GR-L', 'Notio Aigaio'],
    ['GR', 'GR-J', 'Peloponnisos'],
    ['GR', 'GR-H', 'Sterea Ellada'],
    ['GR', 'GR-E', 'Thessalia'],
    ['GR', 'GR-K', 'Voreio Aigaio'],

I have no clue how can I contribute them to the final code, so if anybody is willing to take these corrections and merge them in the final code I would appreciate it!
Also another question is how can these get translated to actual greek names? These here are written with latin characters. How can we have them in en_US and in el_GR?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants