Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #30959

nikolalardev · 2020-11-17T22:42:46Z

Description (*)

Related Pull Requests

https://github.com/magento-commerce/inventory/pull/42

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Install Magento
Check table directory_country_region for Albania,Denmark,Greece,Iceland,Portugal and Sweden states/regions.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #31040: Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden

m2-assistant · 2020-11-17T22:42:48Z

Hi @nikolalardev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

gwharton · 2020-11-21T17:43:48Z

app/code/Magento/Directory/Setup/Patch/Data/AddDataForGreece.php

+            ['GR', 'GR-H', 'Stereá Elláda'],
+            ['GR', 'GR-E', 'Thessalía'],
+            ['GR', 'GR-K', 'Vóreio Aigaío'],
+


Should we also be including GR-69 Ágion Óros, self governed region of Greece

@gwharton I wasn't sure that should be added, but now is there.

gwharton · 2020-11-21T17:45:30Z

app/code/Magento/Directory/Setup/Patch/Data/AddDataForPortugal.php

+            ['PT', 'PT-18', 'Viseu'],
+            ['PT', 'PT-19', 'Região Autónoma dos Açores'],
+            ['PT', 'PT-20', 'Região Autónoma da Madeira']
+        ];


According to ISO 3166-2, the two autonomous regions in Portugal have region codes PT-20 and PT-30. Can we make these consistent.

@gwharton Hello, I fix the this two region codes, good catch. Thank you.

…tes numbers

gabrieldagama · 2020-11-24T17:15:23Z

@magento create issue

gabrieldagama · 2020-11-26T11:09:48Z

@magento run all tests

gabrieldagama

Hi @nikolalardev, thanks for contributing, moving this to the correct state.

gabrieldagama · 2020-11-27T13:04:27Z

@magento run all tests

gabrieldagama · 2020-11-30T10:18:12Z

@magento run all tests

gabrieldagama · 2020-11-30T10:37:48Z

Hi @nikolalardev, please follow the exception being thrown on the tests:

10:27:05 [Build Functional CE] In ErrorHandler.php line 61:
10:27:05 [Build Functional CE]                                                                                
10:27:05 [Build Functional CE]   [Exception]                                                                  
10:27:05 [Build Functional CE]   Warning: call_user_func() expects parameter 1 to be a valid callback, class  
10:27:05 [Build Functional CE]    'Magento\Directory\Setup\Patch\Data\AddDataForGreece' not found in /var/ww  
10:27:05 [Build Functional CE]   w/html/lib/internal/Magento/Framework/Setup/Patch/PatchRegistry.php on line  
10:27:05 [Build Functional CE]    141                                                                         
10:27:05 [Build Functional CE]                                                                                
10:27:05 [Build Functional CE] 
10:27:05 [Build Functional CE] Exception trace:
10:27:05 [Build Functional CE]   at /var/www/html/lib/internal/Magento/Framework/App/ErrorHandler.php:61
10:27:05 [Build Functional CE]  Magento\Framework\App\ErrorHandler->handler() at n/a:n/a
10:27:05 [Build Functional CE]  call_user_func() at /var/www/html/lib/internal/Magento/Framework/Setup/Patch/PatchRegistry.php:141
10:27:05 [Build Functional CE]  Magento\Framework\Setup\Patch\PatchRegistry->getDependencies() at /var/www/html/lib/internal/Magento/Framework/Setup/Patch/PatchRegistry.php:206
10:27:05 [Build Functional CE]  Magento\Framework\Setup\Patch\PatchRegistry->getIterator() at /var/www/html/lib/internal/Magento/Framework/Setup/Patch/PatchApplier.php:138
10:27:05 [Build Functional CE]  Magento\Framework\Setup\Patch\PatchApplier->applyDataPatch() at /var/www/html/setup/src/Magento/Setup/Model/Installer.php:1094
10:27:05 [Build Functional CE]  Magento\Setup\Model\Installer->handleDBSchemaData() at /var/www/html/setup/src/Magento/Setup/Model/Installer.php:960
10:27:05 [Build Functional CE]  Magento\Setup\Model\Installer->installDataFixtures() at n/a:n/a
10:27:05 [Build Functional CE]  call_user_func_array() at /var/www/html/setup/src/Magento/Setup/Model/Installer.php:389
10:27:05 [Build Functional CE]  Magento\Setup\Model\Installer->install() at /var/www/html/setup/src/Magento/Setup/Console/Command/InstallCommand.php:231
10:27:05 [Build Functional CE]  Magento\Setup\Console\Command\InstallCommand->execute() at /var/www/html/vendor/symfony/console/Command/Command.php:255
10:27:05 [Build Functional CE]  Symfony\Component\Console\Command\Command->run() at /var/www/html/vendor/symfony/console/Application.php:1009
10:27:05 [Build Functional CE]  Symfony\Component\Console\Application->doRunCommand() at /var/www/html/vendor/symfony/console/Application.php:273
10:27:05 [Build Functional CE]  Symfony\Component\Console\Application->doRun() at /var/www/html/lib/internal/Magento/Framework/Console/Cli.php:115
10:27:05 [Build Functional CE]  Magento\Framework\Console\Cli->doRun() at /var/www/html/vendor/symfony/console/Application.php:149
10:27:05 [Build Functional CE]  Symfony\Component\Console\Application->run() at /var/www/html/bin/magento:23
10:27:05 [Build Functional CE]

…alardev/magento2 into feature-additional-country-regions

nikolalardev · 2020-12-07T15:29:00Z

@magento run Functional Tests B2B

engcom-Foxtrot · 2020-12-08T10:56:36Z

@magento run all tests

nikolalardev · 2020-12-14T13:36:12Z

@magento run all tests

engcom-Foxtrot · 2020-12-17T13:59:25Z

@magento run all tests

engcom-Foxtrot · 2020-12-18T06:41:19Z

@magento run all tests

nikolalardev · 2020-12-21T13:38:53Z

@magento run all tests

…and Sweden #30959

m2-assistant · 2020-12-24T06:26:59Z

Hi @nikolalardev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden

0a27db2

magento-engcom-team added Component: Directory Release Line: 2.4 labels Nov 17, 2020

gwharton reviewed Nov 21, 2020

View reviewed changes

m2-community-project bot assigned gwharton Nov 21, 2020

m2-community-project bot added this to Review in Progress in Pull Requests Dashboard Nov 21, 2020

m2-community-project bot added the Progress: review label Nov 21, 2020

gwharton reviewed Nov 21, 2020

View reviewed changes

magento#30959 Add one more region for Greece and fix two Portugal sta…

876e37b

…tes numbers

gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 24, 2020

m2-community-project bot added this to Review in Progress in High Priority Pull Requests Dashboard Nov 24, 2020

m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Nov 24, 2020

m2-assistant bot mentioned this pull request Nov 24, 2020

[Issue] Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #31040

Closed

4 tasks

Merge branch '2.4-develop' into feature-additional-country-regions

bcbf38d

gabrieldagama suggested changes Nov 26, 2020

View reviewed changes

m2-community-project bot assigned gabrieldagama Nov 26, 2020

m2-community-project bot moved this from Review in Progress to Changes Requested in High Priority Pull Requests Dashboard Nov 26, 2020

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 26, 2020

Merge branch '2.4-develop' into feature-additional-country-regions

8e1d2d7

magento#30959 Fix typo

c172dc1

engcom-Foxtrot self-assigned this Nov 30, 2020

Merge branch 'feature-additional-country-regions' of github.com:nikol…

93b1d30

…alardev/magento2 into feature-additional-country-regions

m2-community-project bot added the Progress: ready for testing label Dec 3, 2020

engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Dec 3, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 3, 2020

engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 3, 2020

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Dec 3, 2020

Merge branch '2.4-develop' into feature-additional-country-regions

d225a17

m2-community-project bot moved this from Extended Testing (optional) to Ready for Testing in High Priority Pull Requests Dashboard Dec 17, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Dec 17, 2020

engcom-Foxtrot moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Dec 17, 2020

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Dec 17, 2020

engcom-Foxtrot moved this from Extended Testing (optional) to Merge in Progress in High Priority Pull Requests Dashboard Dec 18, 2020

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 18, 2020

nikolalardev added 2 commits December 20, 2020 16:50

Merge branch '2.4-develop' into feature-additional-country-regions

229ecee

Merge branch '2.4-develop' into feature-additional-country-regions

e8cec3b

magento-engcom-team pushed a commit that referenced this pull request Dec 24, 2020

ENGCOM-8505: Add regions for Albania,Denmark,Greece,Iceland,Portugal …

756f74f

…and Sweden #30959

magento-engcom-team merged commit 1d50915 into magento:2.4-develop Dec 24, 2020

gabrieldagama moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Jan 6, 2021

magento-engcom-team removed this from Recently Merged in High Priority Pull Requests Dashboard Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #30959

Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #30959

nikolalardev commented Nov 17, 2020 •

edited by engcom-Foxtrot

Loading

m2-assistant bot commented Nov 17, 2020

gwharton Nov 21, 2020

nikolalardev Nov 21, 2020

gwharton Nov 21, 2020

nikolalardev Nov 21, 2020

gabrieldagama commented Nov 24, 2020

gabrieldagama commented Nov 26, 2020

gabrieldagama left a comment

gabrieldagama commented Nov 27, 2020

gabrieldagama commented Nov 30, 2020

gabrieldagama commented Nov 30, 2020

nikolalardev commented Dec 7, 2020

engcom-Foxtrot commented Dec 8, 2020

nikolalardev commented Dec 14, 2020

engcom-Foxtrot commented Dec 17, 2020

engcom-Foxtrot commented Dec 18, 2020

nikolalardev commented Dec 21, 2020

m2-assistant bot commented Dec 24, 2020

Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #30959

Add regions for Albania,Denmark,Greece,Iceland,Portugal and Sweden #30959

Conversation

nikolalardev commented Nov 17, 2020 • edited by engcom-Foxtrot Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Nov 17, 2020

gwharton Nov 21, 2020

Choose a reason for hiding this comment

nikolalardev Nov 21, 2020

Choose a reason for hiding this comment

gwharton Nov 21, 2020

Choose a reason for hiding this comment

nikolalardev Nov 21, 2020

Choose a reason for hiding this comment

gabrieldagama commented Nov 24, 2020

gabrieldagama commented Nov 26, 2020

gabrieldagama left a comment

Choose a reason for hiding this comment

gabrieldagama commented Nov 27, 2020

gabrieldagama commented Nov 30, 2020

gabrieldagama commented Nov 30, 2020

nikolalardev commented Dec 7, 2020

engcom-Foxtrot commented Dec 8, 2020

nikolalardev commented Dec 14, 2020

engcom-Foxtrot commented Dec 17, 2020

engcom-Foxtrot commented Dec 18, 2020

nikolalardev commented Dec 21, 2020

m2-assistant bot commented Dec 24, 2020

nikolalardev commented Nov 17, 2020 •

edited by engcom-Foxtrot

Loading