Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order item should contain product images #32369

Closed
github-jira-sync-bot opened this issue Mar 4, 2021 · 8 comments · May be fixed by #32433
Closed

Order item should contain product images #32369

github-jira-sync-bot opened this issue Mar 4, 2021 · 8 comments · May be fixed by #32433
Assignees
Labels
Area: Framework Component: GraphQL GraphQL feature request Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@github-jira-sync-bot
Copy link

As a developer I want to have a convenient way to load product images of ordered product, so I don't have to do multiple queries and my PWA app is performant.

AC

  • OrderItemInterface exposes product images

Note: I think we should add variant: ProductInterface field to an order item and do similar in other cases (wishlist, gift registry, purchase order, etc). Need to make sure Nishant and performance team are ok with this approach.

@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-38534

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

Hi @github-jira-sync-bot. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@khrystynastolbova
Copy link
Contributor

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in GraphQL Backlog Mar 10, 2021
khrystynastolbova added a commit to khrystynastolbova/magento2 that referenced this issue Mar 10, 2021
khrystynastolbova added a commit to khrystynastolbova/magento2 that referenced this issue Mar 11, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in GraphQL Backlog Mar 11, 2021
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Mar 18, 2021
@magento-engcom-team magento-engcom-team added this to Pull Request In Progress in High Priority Backlog Nov 8, 2021
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in GraphQL Backlog Nov 8, 2021
@engcom-November
Copy link
Contributor

Considering this as feature request as currently Product images are not loaded with OrderItemInterface. Also ProductInterface field to an order item is not available which is existing behavior of Magento but not a bug.
Ref devdocs

@m2-community-project m2-community-project bot added this to Pull Request in Progress in Feature Requests Backlog Sep 1, 2022
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in High Priority Backlog Sep 1, 2022
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2023

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request in Progress to Ready for Grooming in Feature Requests Backlog Feb 15, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for grooming labels Feb 15, 2023
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 16, 2023

Hey @khrystynastolbova

sorry for the confusion on this ticket,
it is a feature request and as per discussion with the team, hence we are canceling the Jira ticket with reference to the same
Accordingly, we are moving this GitHub ticket to feature request status.

Thanks

@engcom-Alfa engcom-Alfa removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 16, 2023
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request in Progress in Feature Requests Backlog Feb 16, 2023
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Feb 16, 2023
@engcom-Alfa engcom-Alfa added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Progress: PR in progress labels Feb 16, 2023
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Feb 16, 2023
@chernenm chernenm added Priority: P3 May be fixed according to the position in the backlog. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P3 May be fixed according to the position in the backlog. labels May 22, 2023
@m2-community-project m2-community-project bot moved this from Pull Request in Progress to Ready for Grooming in Feature Requests Backlog Aug 1, 2023
@engcom-Bravo
Copy link
Contributor

Hi,

internal team started work on this issue.

Thanks

@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for grooming labels Jan 11, 2024
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Done in Feature Requests Backlog Feb 15, 2024
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: GraphQL GraphQL feature request Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Development

Successfully merging a pull request may close this issue.

7 participants