-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#32369 GraphQL: Order item should contain product images #32433
base: 2.4-develop
Are you sure you want to change the base?
#32369 GraphQL: Order item should contain product images #32433
Conversation
Hi @khrystynastolbova. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
What is this PR waiting on, has been a P1 issue since 18th of March? Would love to see this PR get merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @khrystynastolbova,
Thanks for the contribution!
Please resolve the conflicts so that we can move further with the review process. Meanwhile we are moving this PR On Hold
.
Thanks
@cpartica any updates around this commit? My dev @khalilbensaid96 is trying to show product images in the order list but graphql isn't exposing the product images in that scenario. Thanks. |
@khrystynastolbova did you end up resolving the conflict and making it work? |
Hello @ckshen8! |
Description (*)
ProductInterface field was added to an order item
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Query:
Questions or comments
Contribution checklist (*)