Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32369 GraphQL: Order item should contain product images #32433

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

khrystynastolbova
Copy link
Contributor

Description (*)

ProductInterface field was added to an order item

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Order item should contain product images #32369

Manual testing scenarios (*)

Query:

{
  customer {
    orders {
      items {
        items {
          id
          product {
            image {
              label
            }
            small_image {
              label
            }
          }
        }
      }
    }
  }
}

Знімок екрана 2021-03-11 о 08 50 54

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2021

Hi @khrystynastolbova. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar rogyar self-assigned this Mar 11, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in GraphQL Pull Requests Dashboard Mar 11, 2021
@gabrieldagama gabrieldagama added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Mar 18, 2021
@nrkapoor nrkapoor requested a review from cpartica October 6, 2021 00:17
@m2-community-project m2-community-project bot removed this from Review in Progress in GraphQL Pull Requests Dashboard Nov 8, 2021
@jesse-deboer
Copy link

jesse-deboer commented Dec 14, 2021

What is this PR waiting on, has been a P1 issue since 18th of March?

Would love to see this PR get merged!

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @khrystynastolbova,

Thanks for the contribution!

Please resolve the conflicts so that we can move further with the review process. Meanwhile we are moving this PR On Hold.

Thanks

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Requests Dashboard May 16, 2023
@engcom-Hotel engcom-Hotel moved this from Changes Requested to On Hold in Pull Requests Dashboard May 16, 2023
@m2-community-project m2-community-project bot added Progress: on hold Priority: P3 May be fixed according to the position in the backlog. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Progress: needs update labels May 16, 2023
@chernenm chernenm removed Priority: P3 May be fixed according to the position in the backlog. Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels May 22, 2023
@m2-community-project m2-community-project bot moved this from On Hold to Changes Requested in Pull Requests Dashboard May 22, 2023
@m2-community-project m2-community-project bot moved this from On Hold to Changes Requested in Pull Requests Dashboard May 22, 2023
@ckshen8
Copy link

ckshen8 commented May 2, 2024

@cpartica any updates around this commit? My dev @khalilbensaid96 is trying to show product images in the order list but graphql isn't exposing the product images in that scenario. Thanks.

@ckshen8
Copy link

ckshen8 commented May 13, 2024

@khrystynastolbova did you end up resolving the conflict and making it work?

@khrystynastolbova
Copy link
Contributor Author

@khrystynastolbova did you end up resolving the conflict and making it work?

Hello @ckshen8!
As I see these changes have already been merged from another commit da53de6
The changes should be available in version 2.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SalesGraphQl Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: GraphQL Release Line: 2.4
Projects
Pull Requests Dashboard
  
Changes Requested
Development

Successfully merging this pull request may close these issues.

Order item should contain product images
10 participants