Let's discuss approved PRs

[ihor-sviziev]

I created this task to provide a list of PRs that should be re-triaged from the developer experience point of view, and probably we should raise the priority of them.

Here is a list of PRs that I'd like to discuss, groped by the decision that was done:

Increased priority to high (p1 or p2):

• Avoid binding magnifier events in duplicate on resize #30695 - improves performance on the frontend
• Removed code redundancy for module frontend layouts. #30644 - removes setting not needed page layout. It's not so easy to change it if you would like to use a different layout
• Catch php syntax errors (or other errors) in bin/magento and output the error instead of staying silent #32145 - PHP syntax errors not catch
• Fix issue #24635: Use of undefined constant GLOB_BRACE in dependency … #31296 - fixes an issue when running Magento on PHP in docker using Alpine Linux
• Move assign category ids to beforeToHtml instead inside load collection #32390 - improves backward compatibility that we recently broke, and no alternative provided from an extensibility point of view
• Seperate js out template to avoid render issue #32434 - fixes PHP ParseError in admin when HTML minification enabled
• Item resolvers should be optional #30823 - fixes object creation when configurable and grouped product modules are disabled (for instance, in case if shop contains only simple products, it might be disabled due to performance reasons)
• Add event listeners passive for fotorama lib improves lighthouse metrics #31080 - improves lighthouse / google page speed metric, got stuck for 3 months already in "Accept" column
• Update Api functional test install-config-mysql file template #30995 - fixes missing mandatory params for running tests
• Incorrect Annotation for Magento\Framework\App\CacheInterface::load #31987 - fixes incorrect return type (missing bool type) that was confusing from the developer perspective when working with the cache. SVC should be approved

Fixed in a different PR:

• Allow higher versions of phpstan to be installed (Magento 2.4 edition) #31972 - allow updating phpstan to newer versions. New versions contain bug fixes and false positives

Decided to be rejected:

• Reuse password reset tokens until they expire #25280 - significantly improves customer experience when some forgot password email got delayed

Still requires discussion:

• Magento fails on captcha even it not used  #30991 - absolutely not an expected issue, failing during object creation. It reproduces mainly on Docker-based installations, as quite often PHP extensions are build from sources there
• Fixed use inconsistently viewModels in codebase #31503 - fixes inconsistency between different pieces in Magento. Such inconsistency causing harder understanding how it should be
• Add variable font size for input display on iOS #32253 - improves customer experience on iPhone. Mobile is really a major part of traffic right now
• Refactor: Swatches Helper / Remove misleading aliases, refactor the class #31355 - improves maintainability. Fixes confusing aliases for classes/interfaces

[m2-assistant]

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

As we discussed with @gabrieldagama - the issues were reviewed and updated priority for those that are really important.
I'm closing this issue, as no action items left here.