Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable font size for input display on iOS #32253

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Feb 23, 2021

Description (*)

This PR just improvement add variable default for input allow reuse in frontend
Before if we set font size below 16px when focus input display on iOS devices will zoom screen
With this variable FE devs can reuse or re-define they own value

https://stackoverflow.com/questions/2989263/disable-auto-zoom-in-input-text-tag-safari-on-iphone
https://www.warrenchandler.com/2019/04/02/stop-iphones-from-zooming-in-on-form-fields/

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Go to real mobile device
  2. Navigate to search input
  3. Focus to input by search something

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add variable font size for input display on iOS #32261: Add variable font size for input display on iOS

@m2-assistant
Copy link

m2-assistant bot commented Feb 23, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn force-pushed the add-variable-input-font-size-for-mobile-ios-devices branch from 3a07a28 to ad4821c Compare February 23, 2021 10:41
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Feb 23, 2021
@ihor-sviziev ihor-sviziev self-assigned this Feb 23, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 23, 2021

@magento run Static Tests, Integration Tests, Functional Tests EE

@gabrieldagama gabrieldagama added the Priority: P3 May be fixed according to the position in the backlog. label Feb 23, 2021
@gabrieldagama
Copy link
Contributor

@magento create issue

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 24, 2021

@magento run Static Tests, Functional Tests EE

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8810 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento run Static Tests, Functional Tests EE

@ihor-sviziev ihor-sviziev mentioned this pull request Mar 30, 2021
16 tasks
@mrtuvn mrtuvn marked this pull request as draft March 20, 2023 14:25
@engcom-Bravo
Copy link
Contributor

Hi @mrtuvn,

We are closing this PR.The PR is in Draft since longtime.

Once you are ready Please feel free to reopen it to process the PR further.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Award: category of expertise Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add variable font size for input display on iOS
5 participants