Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unwated js called on Frontend via Require js #32985

Closed
ia-gaurav opened this issue May 10, 2021 · 9 comments
Closed

Removed unwated js called on Frontend via Require js #32985

ia-gaurav opened this issue May 10, 2021 · 9 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@ia-gaurav
Copy link

Magento Version : 2.4.1

Issue - There are many unwated js called on frontend via require js , i am not getting any way to remove this

Example Js - color-picker.js, tinycolor.js

@ia-gaurav ia-gaurav added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 10, 2021
@m2-assistant
Copy link

m2-assistant bot commented May 10, 2021

Hi @ia-gaurav. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor

mrtuvn commented May 10, 2021

This already done in this PR
#30647 (authentication-popup.js) (In progress) not available GA
#28400 (spectrum.js, tinycolor.js) (In progress) not available GA
calendar.js (merged)
#27618 (improvements MutationObserver es6-collections polyfill) merged
improved condition load date-picker (merged)

(jquery draggable/resizeable)
#32802
#32756

more extra improve may need workarounds on
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Theme/view/base/requirejs-config.js

There are also have room for improvements
tabs.js, moment.js, effect.js

@ia-gaurav
Copy link
Author

how can i pull these in my current version of magento

@ia-gaurav
Copy link
Author

@mrtuvn - please help me way to pull changes to avoid unwated js call

@mrtuvn
Copy link
Contributor

mrtuvn commented May 13, 2021

You can get these update by update your magento instance to higher version possible (no need futher action). But if you want all to use. You need to create you own patches and pick them one by one to your patch file (take time, effort if you want apply patches feature early to store)
Some useful tools
https://github.com/cweagans/composer-patches
https://github.com/AmpersandHQ/ampersand-magento2-upgrade-patch-helper
Do you have tech or development knowledges

@engcom-Lima engcom-Lima self-assigned this Jun 8, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 8, 2021

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Lima
Copy link
Contributor

Hi @ia-gaurav,

This issue still exist. If Yes then Can you please tell some details regarding this ticket?

Have you reproduce this issue magento 2.4-develop or 2.4.2? If yes can you please provide me some reproducible steps and screenshots? that would be helpful.

Thanks for the understanding!

@engcom-Lima engcom-Lima added the Issue: needs update Additional information is require, waiting for response label Jun 10, 2021
@engcom-Lima
Copy link
Contributor

Hi @ia-gaurav

We are expecting that your issue got resolved because we did not any update from you. Hence we are closing this ticket.

Please feel free to raise the new ticket or open the existing ticket with reproducible steps and details.

Thanks

@ia-gaurav
Copy link
Author

@engcom-Lima - i want these unwated file to not load at user frontend part can you tell way to remove those

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

3 participants