Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Token Exchange Expiration Period Is Not Calculated Correctly #3449

Closed
gary287 opened this issue Feb 17, 2016 · 4 comments
Closed

OAuth Token Exchange Expiration Period Is Not Calculated Correctly #3449

gary287 opened this issue Feb 17, 2016 · 4 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@gary287
Copy link

gary287 commented Feb 17, 2016

The expiration period setting has a note below it that says "Consumer key/secret will expire if not used within X seconds after Oauth token exchange starts." It would be great if it worked that way but it does not. The consumer key/secret expires X seconds after the consumer is created. This is true regardless of whether you click activate or reauthorize on an integration. It is always based on the creation date of the consumer which does not change. Either the consumer creation date needs to be reset whenever a new token exchange starts or preferably the expiration date would be based on the creation date of the verifier token.

@vzabaznov vzabaznov added the PS label Mar 12, 2016
@arkadiych
Copy link
Contributor

Thanks for reporting this issue. Internal issue MAGETWO-51292

@mazhalai mazhalai added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 29, 2016
@jim5359
Copy link

jim5359 commented Apr 4, 2016

This problem breaks the Reauthorize. i.e. If you have an existing integration that's been authorized and click the Reauthorize now your integration is broken because it says the consumer key is expired. The only way to fix it is to delete the integration and create a new one from scratch.

@choukalos
Copy link

This fix is in review and will be merged to mainline soon; it's slated to be patched back into 2.0.x in an upcoming patch release.

magento-team pushed a commit that referenced this issue Apr 20, 2016
… Calculated Correctly #3449

 - change consumer expiration to be based on time token exchange starts instead of when consumer is created
magento-team pushed a commit that referenced this issue Apr 20, 2016
… Calculated Correctly #3449

 - fix static test failures
 - update unit tests
magento-team pushed a commit that referenced this issue Apr 20, 2016
magento-team pushed a commit that referenced this issue Apr 20, 2016
… Calculated Correctly #3449

 - fixed api-functional test
magento-team pushed a commit that referenced this issue Apr 20, 2016
… Calculated Correctly #3449

 - changed SQL to use UTC_TIMESTAMP to correctly calculate datetime diffs without adjusting for time zone
magento-team pushed a commit that referenced this issue Apr 20, 2016
… Calculated Correctly #3449

 - improved how updated date is compared against expiration limit
magento-team pushed a commit that referenced this issue Apr 20, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
… Calculated Correctly #3449

 - change consumer expiration to be based on time token exchange starts instead of when consumer is created
okorshenko pushed a commit that referenced this issue May 17, 2016
… Calculated Correctly #3449

 - fix static test failures
 - update unit tests
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
… Calculated Correctly #3449

 - fixed api-functional test
okorshenko pushed a commit that referenced this issue May 17, 2016
… Calculated Correctly #3449

 - changed SQL to use UTC_TIMESTAMP to correctly calculate datetime diffs without adjusting for time zone
okorshenko pushed a commit that referenced this issue May 17, 2016
… Calculated Correctly #3449

 - improved how updated date is compared against expiration limit
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
okorshenko pushed a commit that referenced this issue May 17, 2016
@elenleonova
Copy link

The issue was fixed as a part of 2.0.6

pdohogne-magento pushed a commit that referenced this issue Nov 28, 2018
[trigger] MAGETWO-95892: Selecting Gift Wrapping for items redirects on 404 Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants