Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters not working on category pages in 2.4.5 #35960

Closed
1 of 5 tasks
harleeniweb opened this issue Aug 17, 2022 · 14 comments · Fixed by #35986
Closed
1 of 5 tasks

Filters not working on category pages in 2.4.5 #35960

harleeniweb opened this issue Aug 17, 2022 · 14 comments · Fixed by #35986
Assignees
Labels
duplicate Reported on 2.4.5 Indicates original Magento version for the Issue report.

Comments

@harleeniweb
Copy link

Preconditions and environment

  • Magento version - 2.4.5

Steps to reproduce

Set Display Out of Stock Products to Yes in the configuration under Store > Configuration > Catalog > Inventory in the admin.

Expected result

Filters should only show matching results on the category pages

Screenshot 2022-08-17 at 9 11 07 am

Actual result

Instead it shows all the products in that category and works fine if I set Display Out of Stock Products to No

Screenshot 2022-08-17 at 9 20 04 am

Additional information

This seems to be the getProductsIdsBySaleability function resetting the filtered products items added in the SearchResultApplier file.

https://github.com/magento/magento2/blob/2.4.5/app/code/Magento/Elasticsearch/Model/ResourceModel/Fulltext/Collection/SearchResultApplier.php
Screenshot 2022-08-17 at 9 24 39 am

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2022

Hi @harleeniweb. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@harleeniweb harleeniweb changed the title Filters not working on PDP Filters not working on PDP in 2.4.5 Aug 17, 2022
@harleeniweb harleeniweb changed the title Filters not working on PDP in 2.4.5 Filters not working on category pages in 2.4.5 Aug 17, 2022
@engcom-Bravo engcom-Bravo added the Reported on 2.4.5 Indicates original Magento version for the Issue report. label Aug 17, 2022
@engcom-Bravo engcom-Bravo self-assigned this Aug 17, 2022
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2022

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @harleeniweb,

Thank you for reporting and collaboration.

When we are Set Display Out of Stock Products to Yes in the configuration we are not able to select size and color, but in your expected result we are able to select size and color.

Kindly provide exact steps to reproduce to replicate the issue.

Thanks,

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Aug 17, 2022
@harleeniweb
Copy link
Author

Hi @engcom-Bravo

you can replicate the issue with any filter that's displaying in the sidebar after the setting is set to Yes.

@gwharton
Copy link
Contributor

Duplicate of #35899

@gwharton
Copy link
Contributor

F.Y.I. this is the commit that broke it. 3a889f4

@maconeto
Copy link

i got the same issue on my environment

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

Hi @harleeniweb,

Thanks for the update. Verified the issue on Magento 2.4-develop branch and the issue is reproducible with above steps to reproduce. however, similar issue has been confirmed here.

We are closing this issue as duplicate.

Thanks.

@engcom-Bravo engcom-Bravo added duplicate and removed Issue: needs update Additional information is require, waiting for response labels Aug 18, 2022
@madbounce
Copy link

@magento give me 2.4.3 instance

@magento-deployment-service
Copy link

Hi @madbounce. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Reported on 2.4.5 Indicates original Magento version for the Issue report.
Projects
None yet
5 participants