-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters not working on category pages in 2.4.5 #35960
Comments
Hi @harleeniweb. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Bravo. Thank you for working on this issue.
|
Hi @harleeniweb, Thank you for reporting and collaboration. When we are Set Display Out of Stock Products to Yes in the configuration we are not able to select size and color, but in your expected result we are able to select size and color. Kindly provide exact steps to reproduce to replicate the issue. Thanks, |
you can replicate the issue with any filter that's displaying in the sidebar after the setting is set to Yes. |
Duplicate of #35899 |
F.Y.I. this is the commit that broke it. 3a889f4 |
i got the same issue on my environment |
@magento give me 2.4-develop instance |
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Bravo, here is your Magento Instance: https://83366bf3e6aae7029e1d0092bf9a3e94.instances.magento-community.engineering |
Hi @harleeniweb, Thanks for the update. Verified the issue on Magento 2.4-develop branch and the issue is reproducible with above steps to reproduce. however, similar issue has been confirmed here. We are closing this issue as duplicate. Thanks. |
@magento give me 2.4.3 instance |
Hi @madbounce. Thank you for your request. I'm working on Magento instance for you. |
Hi @madbounce, here is your Magento Instance: https://112719a7477c04ae61ec6c268ff3f549.instances.magento-community.engineering |
Preconditions and environment
Steps to reproduce
Set Display Out of Stock Products to Yes in the configuration under Store > Configuration > Catalog > Inventory in the admin.
Expected result
Filters should only show matching results on the category pages
Actual result
Instead it shows all the products in that category and works fine if I set Display Out of Stock Products to No
Additional information
This seems to be the getProductsIdsBySaleability function resetting the filtered products items added in the SearchResultApplier file.
https://github.com/magento/magento2/blob/2.4.5/app/code/Magento/Elasticsearch/Model/ResourceModel/Fulltext/Collection/SearchResultApplier.php
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: