Fixed Issue #35899: Filtering with out of stock products, limited only to products in…

[Bashev]

… result.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Catalog shown entire catalog items count if show_of_stock_option enabled #35899
2. Fixes Filters not working on category pages in 2.4.5 #35960
3. Fixes Magento 2.4.5: Show Out Of Stock option outputs all available products during search #36055

Manual testing scenarios (*)

see #35899

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Bashev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Bashev]

@magento give me test instance

[magento-deployment-service]

Hi @Bashev. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @Bashev, here is your Magento Instance: https://6c47719a347a32524462556a3ad7898d.instances.magento-community.engineering
Admin access: https://6c47719a347a32524462556a3ad7898d.instances.magento-community.engineering/admin_30b6
Login: 7c991b5b
Password: 8e8cf10bad97

[Bashev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Bashev]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Bashev]

@magento run Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Bashev]

@magento run Integration Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Bashev]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[i6media]

Issue doesn't seem resolved by merged commit, please refer to: #35899 (comment)

[i6media]

For people looking for a temporary hotfix: https://github.com/plumrocket/module-layered-navigation-fix-magento-2.4.5

[FadedOut]

For people looking for a temporary hotfix: https://github.com/plumrocket/module-layered-navigation-fix-magento-2.4.5

Awesome, this seemed to do it for me. The count is correct as well as the filtering.

For anyone else coming across this and wants to use that file, there aren't any instructions. So in case anyone might be slightly confused this is what I did (there might be other ways, like maybe composer require, but this I found worked for me):

• I downloaded the zip of that file (Code > Download ZIP)
• Navigate to ./app/code/ and make a folder called: Plumrocket
• Go into newly created folder (Plumrocket)
• Make new folder called: ProductFilterFixMagento245
• Add contents of downloaded ZIP into that folder (contents: etc, Model, registration.php)

Run your normal commands

for example:

php bin/magento setup:upgrade ; php bin/magento setup:di:compile ; php bin/magento setup:static-content:deploy ; php bin/magento cache:flush ; php bin/magento cache:clean

Thanks to the great help out there fixing up these constant regressions during these "updates". Every update there is always serious regressions. I wonder who tests these "updates"...

[mobweb]

For people looking for a temporary hotfix: https://github.com/plumrocket/module-layered-navigation-fix-magento-2.4.5

This helped me fix the issue on regular category pages, but on a category page where a filter is applied, the sorting by "is_salable" is lost.

However, the fix proposed in this issue does not solve the issue at all, at least for me.