-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exception.log missing #36054
Comments
Hi @siliconalchemy. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
We have the same issue since 2.4.3-p1 / 2.4.4 |
Same here. 2.4.4 EE. We suspect there is a gap between the preg_match used in module-support and some new log formatting. The matching expressions might need an update to start working correctly again. |
We tested that on a vanilla 2.4.4 (Community) in the exception.log is not written there. Would be nice to get some feedback from Magnet here. It's difficult to debug stuff when there is no clue about what happens. |
Any updates on this? Nobody seems to care about such a severe issue. |
@sdzhepa: can we have somebody to verify this? This indeed sounds like a P0 or P1 prio if it's true. Thanks! I can not confirm that this is true on Magento 2.4.3-p3 on production shops of ours, it works as expected over there. We haven't tried 2.4.4 or 2.4.5 yet in production, so I can't speak about those versions yet. |
We're having this issue on 2.4.4 (CE). It seems that some errors are written to the system.log. |
In our case the exceptions seem to be written into the system.log instead of the exception.log (2.4.4 CE). The exception.log stays empty. |
Hi @engcom-November. Thank you for working on this issue.
|
Verified the issue on fresh instance of 2.4.5 Project-community-edition and the issue is reproducible. exception.log file is missing in var/log folder. No errors are written into exception.log. Only all errors are written into system.log file. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-6796 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
We also re-look at this one as well |
Hello, As I can see this issue got fixed in the scope of the internal Jira ticket ACP2E-1287 by the internal team Based on the Jira ticket, the target version is 2.4.6. Thanks |
If anyone wants a patch based on the commits from above (which work on Magento 2.4.5, haven't tested on 2.4.4), this one can be applied against the |
Thanks for the patch. |
Just a quick note to say this worked for me: https://magento.stackexchange.com/questions/361276/exception-log-is-missing-in-magento2-4-4 --- a/vendor/magento/framework/Logger/Handler/System.php
+++ b/vendor/magento/framework/Logger/Handler/System.php
@@ -55,7 +55,7 @@
*/
public function write(array $record): void
{
- if (isset($record['context']['exception'])) {
+ if (isset($record['context']['exception']) || $record['level'] == Logger::CRITICAL) {
$this->exceptionHandler->handle($record);
return;
|
Is there a patch available or do we have to wait until 2.4.6? |
2.4.6 is out and includes this patch/fix. |
@siliconalchemy So we have to upgrade to 2.4.6 to fix it? |
Hi @Eddcapone - For the temp purpose you can try the below solution We tried that and it seems working. |
@MeetKamal But this requires us to do a change in the core. Why is there no official patch? |
@Eddcapone Here i am attach the patch file, you can use this patch untill the your system is not being updated to the 2.4.6 |
Or use my earlier referenced patch that is based on the official Adobe fix? (A lot time of could have been won if you just had read all the comments in this thread 😉) |
My question is wether there is an official patch and if not why not? |
There isn't as far as I know, at least I can't find one when searching using their quality patches tool. As to why not, no idea, but probably Adobe didn't feel like it was important enough to create one... So either take one of the solutions here from the thread, or make one yourself if you don't trust it (which is what I would recommend), or upgrade to 2.4.6-p1, or if you really want an official patch, create an issue or pull request here: https://github.com/magento/quality-patches (but knowing Adobe, it might take some weeks/months/years until you'll get one) |
@hostep, Thx! It is beyond me how there is no official patch for such an important bug |
I tried your patch. I copied it to vendor/magento/framework and executed |
|
Is there a patch already? |
No I created the new one because on my site exception logs were not creating |
Why do they close it if there is no official patch? |
@Eddcapone: it was fixed in Magento 2.4.6, so why shouldn't they close it? |
@hostep Because not everyone can just upgrade to 2.4.6, it is a long process if you have many third party extensions and customisations. And your patch is not official. |
😆 In that thought process they need to leave open every ticket for forever and never close one, because there will always be a user that can't update to some version. Anyway, if a fix has been published, they close the issue, it's as simple as that. My patch isn't official, that's very true, if you don't trust it, then please make your own patch, the commits with fixes were already mentioned earlier: #36054 (comment) There is no other way you'll get what you want, so please get into the habit of creating your own patches for bugs you need to have fixed, you're bound to run into another bug in the future that has been fixed in some commit, so it's a good skill to have to turn those commits into patches. |
Preconditions and environment
This Magento install has
Steps to reproduce
Trigger an exception/error (for example reCAPTCHA error detailed in #34975), or make
generated/
directory read-only to trigger a read-only error.Expected result
I expect to see an error and trace in var/log/exception.log
Actual result
No exception.log exists. Errors do seem to appear in system.log, but I don't know if they are everything that should be in exception.log.
Additional information
This instance of Magento has been updated since 2.0 to 2.2 and 2.4. In the past exception.log was always present with errors/exceptions.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: