Missing dependency on web-token/jwt-easy?

[hostep]

Preconditions and environment

• Magento version 2.4-develop

Steps to reproduce

1. Look at this line of code:

   magento2/app/code/Magento/JwtFrameworkAdapter/Model/AlgorithmProviderFactory.php

   Line 11 in ca30c47

   use Jose\Easy\AlgorithmProvider;

   (it mentions the namespace Jose\Easy)
2. This class (Jose\Easy\AlgorithmProvider) is nowhere to be found in the magento codebase after installing all composer dependencies

Expected result

Magento should use code that's included, it shouldn't use code that's not included as this will crash.

Actual result

Found referenced code that's not present in the codebase.

Additional information

I suspect this happened because:

1. This code was introduced in February 2021
2. In November 2022, the web-token/jwt-framework package was updated from version v2.2.11 to 3.1.2
3. If we take a look at the changes between those 2 versions, we can see that the Jose\Easy\AlgorithmProvider got removed from web-token/jwt-framework

Possible solution: add a requirement on web-token/jwt-easy, however, that package is considered abandoned, so not sure if that's the best way forward here?

Also: there are probably too few automated tests for this JwtFrameworkAdapter magento module, otherwise this would have been catched earlier...

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @hostep. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @hostep,

Thank you for report and collaboration!

As you mentioned the web-token/jwt-easy has been abandoned and no longer being used.
But Jose\Easy\AlgorithmProvider has been referenced even though it is not present.

Hence we can confirm the issue.

Thanks.

[github-jira-sync-bot]

❌ Something went wrong. Cannot create Jira issue.

[github-jira-sync-bot]

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-9232

[yegxr]

@magento I am working on this