Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#37783 Missing dependency on web-token/jwt-easy? #38072

Merged
merged 4 commits into from
Dec 8, 2023
Merged

magento/magento2#37783 Missing dependency on web-token/jwt-easy? #38072

merged 4 commits into from
Dec 8, 2023

Conversation

yegxr
Copy link

@yegxr yegxr commented Oct 13, 2023 •
edited
Loading

-Removed an unused dependency in the code

Description (*)

The unused AlgorithmProviderFactory class was removed, as well as dependencies on this class in such classes as:
JweAlgorithmManagerFactory.php, JweContentAlgorithmManagerFactory.php, JwsAlgorithmManagerFactory.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Missing dependency on web-token/jwt-easy? #37783

Manual testing scenarios (*)

  1. Tested the class dependencies in the project
  2. Found 3 dependencies in the files JweAlgorithmManagerFactory.php, JweContentAlgorithmManagerFactory.php, JwsAlgorithmManagerFactory
  3. Dependencies were only in construct but were not used in any way
  4. Deleted dependencies in construct and the class itself

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

magento#37783 Missing dependency on web-token/jwt-easy?
9991c1e 
-Removed an unused dependency in the code
@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2023

Hi @yegxr. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added the partners-contribution Pull Request is created by Magento Partner label Oct 13, 2023
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Oct 13, 2023
@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 13, 2023
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Oct 13, 2023
@m2-community-project m2-community-project bot added this to Pending Review in Community Dashboard Oct 13, 2023
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Oct 13, 2023
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 16, 2023
@engcom-Hotel
Copy link
Contributor

@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel self-requested a review October 16, 2023 12:09
@engcom-Hotel engcom-Hotel moved this from Pending Review to Review in Progress in Community Dashboard Oct 16, 2023
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel
engcom-Hotel approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Approved

Failed tests seems flaky to me

@m2-community-project m2-community-project bot moved this from Review in Progress to Ready for Testing in Community Dashboard Oct 17, 2023
@engcom-Charlie engcom-Charlie self-assigned this Oct 26, 2023
@engcom-Charlie engcom-Charlie moved this from Ready for Testing to Testing in Progress in Community Dashboard Oct 30, 2023
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Oct 31, 2023 •
edited
Loading

QA passed

No manual testing required for this PR as the deprecated/unused class and dependencies has been removed. Hence moving it further.

@engcom-Charlie engcom-Charlie moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Oct 31, 2023
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

The functional b2b test failures are different in recent 2 builds. The test failures neither part of PR nor failing because of PR changes. Hence moving the PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38072/48ed34d19dd8493136b8906be2edfccc/Functional/allure-report-b2b/index.html
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38072/4a4880335e4dcf7dbcb78a4eaaffe86d/Functional/allure-report-b2b/index.html#categories
image

@engcom-Charlie engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Oct 31, 2023
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 1bb5543 into magento:2.4-develop Dec 8, 2023
11 of 12 checks passed
@engcom-Echo engcom-Echo moved this from Merge in Progress to Recently Merged in Community Dashboard Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

Labels
Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Community Dashboard
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency on web-token/jwt-easy?
7 participants
@yegxr @engcom-Hotel @engcom-Charlie @sinhaparul @engcom-Bravo @magento-devops-reposync-svc @m2-github-services