Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.7 : Can't translate FPT text on checkout/cart page #5477

Closed
kanduvisla opened this issue Jul 5, 2016 · 9 comments · Fixed by #28108
Closed

2.0.7 : Can't translate FPT text on checkout/cart page #5477

kanduvisla opened this issue Jul 5, 2016 · 9 comments · Fixed by #28108
Assignees
Labels
Area: Frontend Component: Tax Component: Translation Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@kanduvisla
Copy link
Contributor

kanduvisla commented Jul 5, 2016

Preconditions:

Magento 2.4-develop
Php v 7.3

Steps to reproduce

  1. Enable FPT in admin; (Go to Admin->Stores->Configuration->Sales->Tax->Fixed Product Taxes);
  2. Change translate to FPT FPT,FPT(translate) for example (app/code/Magento/Weee/i18n/en_US.csv);
  3. Create simple product with FPT attribute and set value for it;
    Screenshot from 2020-04-30 12-05-32
  4. Go to Storefront;
  5. Add created before the product to Cart;
  6. Go to Shopping Cart;

✔️ The FPT has been translated
screenshot
7. Proceed to Checkout;
8. Fill all required fields and go to Review&Payment step;

Actual Result:

✖️ The FPT was not translated
screenshot_1

Expected Result:

✔️ The FPT must be translated

I try to translate the text 'FPT' in the checkout page but nothing seems to work:
I try with a language pack in app/i18n/Vendor/nl_nl/nl_NL.csv (the rest of the translations of this pack work so it is loaded):

"FPT","Verwijderingsbijdrage",module,Magento_Weee
"Magento_Weee::FPT","Verwijderingsbijdrage",module,Magento_Weee

I try with the file app/design/frontend/Vendor/Theme/i18n/nl_NL.csv:

"FPT","Verwijderingsbijdrage"
"Magento_Weee::FPT","Verwijderingsbijdrage"

I try with the file app/code/Magento/Weee/i18n/nl_NL.csv:

FPT,Verwijderingsbijdrage

I try by adding an entry to the 'translation'-table in the database (even had to manually check the crc_string):

key_id  string  store_id    translate               locale  crc_string
2       FPT     0           Verwijderingsbijdrage   nl_NL   1575739609

All with no success.
I'm running out of options. Is there any spot I missed where I need to put my translation? Can anyone confirm / try if the text 'FPT' in the checkout/cart page is translatable?

@vkorotun vkorotun removed the PS label Aug 4, 2016
@veloraven veloraven self-assigned this Aug 4, 2016
@veloraven
Copy link
Contributor

@kanduvisla thank you for your report.
Internal ticket MAGETWO-56471 was created for this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 5, 2016
@veloraven veloraven removed their assignment Aug 5, 2016
@veloraven
Copy link
Contributor

veloraven commented Aug 5, 2016

Has a fix in #5732
Duplicate #5731

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Component: Translation Component: Tax labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@kanduvisla, thank you for your report.
The issue is already fixed in 2.2.0

@magento-engcom-team magento-engcom-team added 2.0.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Sep 20, 2017
magento-engcom-team pushed a commit that referenced this issue Mar 20, 2020
@hostep
Copy link
Contributor

hostep commented Apr 10, 2020

Re-opening because the FPT label is not translatable yet on the checkout page (second step).

The fix was only done to the checkout_cart_index.xml file in #9204, but was forgotten to be done to the checkout_index_index.xml file.

@hostep hostep reopened this Apr 10, 2020
@ghost ghost removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Apr 10, 2020
@ghost ghost added this to Ready for QA in Community Backlog Apr 10, 2020
@engcom-Alfa engcom-Alfa self-assigned this Apr 30, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 30, 2020
@ghost ghost unassigned engcom-Alfa Apr 30, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog Apr 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 30, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-33870 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Charlie engcom-Charlie self-assigned this May 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 5, 2020

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog May 5, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog May 5, 2020
@ihor-sviziev ihor-sviziev linked a pull request May 5, 2020 that will close this issue
4 tasks
@ihor-sviziev ihor-sviziev removed Fixed in 2.2.x The issue has been fixed in 2.2 release line bug report labels May 5, 2020
@ghost ghost added Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Priority: P3 May be fixed according to the position in the backlog. labels May 6, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 21, 2020
@slavvka
Copy link
Member

slavvka commented May 21, 2020

Hi @kanduvisla. Thank you for your report.
The issue has been fixed in #28108 by @engcom-Charlie in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@slavvka slavvka closed this as completed May 21, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog May 21, 2020
@magento-engcom-team magento-engcom-team removed this from Done (last 30 days) in Community Backlog May 21, 2020
@sdzhepa sdzhepa removed the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Tax Component: Translation Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging a pull request may close this issue.