Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't translate FPT text on checkout/cart page #28108

Merged
merged 2 commits into from
May 21, 2020
Merged

Can't translate FPT text on checkout/cart page #28108

merged 2 commits into from
May 21, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Added translate

Related Pull Requests

Fixed Issues (if relevant)

  1. 2.0.7 : Can't translate FPT text on checkout/cart page #5477: Can't translate FPT text on checkout/cart page

Manual testing scenarios (*)

Please see #5477

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 5, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard May 5, 2020
@ihor-sviziev ihor-sviziev linked an issue May 5, 2020 that may be closed by this pull request
2.0.7 : Can't translate FPT text on checkout/cart page #5477
Closed
@ihor-sviziev ihor-sviziev self-assigned this May 5, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label May 5, 2020
@ihor-sviziev
Copy link
Contributor

Hi @engcom-Charlie,
Do you think it will be too hard to cover this change by some integration test?

@engcom-Charlie
Copy link
Contributor Author

engcom-Charlie commented May 5, 2020 •
edited
Loading

Hi @ihor-sviziev,
I don't think it makes sense to write a test for such a small change, the complexity of writing a test doesn't match the severity of the issue.

@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard May 5, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7521 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 6, 2020
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 6, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Enable FPT in admin; (Go to Admin->Stores->Configuration->Sales->Tax->Fixed Product Taxes);
  2. Change translate to FPT FPT,FPT(translate) for example (app/code/Magento/Weee/i18n/en_US.csv);
  3. Create simple product with FPT attribute and set value for it;
    Screenshot from 2020-04-30 12-05-32
  4. Go to Storefront;
  5. Add created before the product to Cart;
  6. Go to Shopping Cart;
  7. Proceed to Checkout;
  8. Fill all required fields and go to Review&Payment step;

Before:

✖️ The FPT was not translated
screenshot_1

After:
✔️ The FPT phrase has been translated
screenshot

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard May 6, 2020
@engcom-Echo engcom-Echo self-assigned this May 6, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Echo engcom-Echo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard May 6, 2020
@ghost ghost added the Progress: accept label May 6, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 6, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 6, 2020
@VladimirZaets VladimirZaets moved this from Merge in Progress to Extended Testing (optional) in Pull Requests Dashboard May 19, 2020
@VladimirZaets VladimirZaets added Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Progress: extended testing Progress: accept labels May 19, 2020
@sdzhepa sdzhepa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels May 20, 2020
@ghost ghost moved this from Extended Testing (optional) to Ready for Testing in Pull Requests Dashboard May 20, 2020
@ghost ghost assigned sdzhepa May 20, 2020
@sdzhepa sdzhepa moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard May 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-7521 has been created to process this Pull Request

@sdzhepa sdzhepa moved this from Testing in Progress to Merge in Progress in Pull Requests Dashboard May 20, 2020
@slavvka slavvka mentioned this pull request May 21, 2020
Closed
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7521: Can't translate FPT text on checkout/cart page #28108
304d2bf
@slavvka slavvka merged commit 0139065 into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@sdzhepa sdzhepa sdzhepa approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@sdzhepa sdzhepa

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Weee Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

2.0.7 : Can't translate FPT text on checkout/cart page
8 participants
@engcom-Charlie @ihor-sviziev @magento-engcom-team @engcom-Alfa @engcom-Echo @sdzhepa @VladimirZaets @slavvka