Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL key for specified store already exists in Magento 2.1.1 #6671

Closed
sanjayjethva opened this issue Sep 20, 2016 · 100 comments
Closed

URL key for specified store already exists in Magento 2.1.1 #6671

sanjayjethva opened this issue Sep 20, 2016 · 100 comments
Assignees
Labels
bug report Component: CatalogUrlRewrite Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@sanjayjethva
Copy link

sanjayjethva commented Sep 20, 2016

I am facing "URL key for specified store already exists" error when i am trying to update existing category name as its appearing in some categories.

I am using Magento 2.1.1.
I have read so many articales where it stated that it is solved in magento 2.1 version but its appearing again. Let me know
Please help me to resolve the issue.

Thanks

Preconditions

Magento 2.1.1

Steps to reproduce

Try to update the name of existing category as its appearing in some categories

Expected result

Category's name is updated

Actual result

"URL key for specified store already exists" error

@miakusha
Copy link
Contributor

Hi @sanjayjethva, Please format your issue description according to the Issue reporting guidelines.

@mgomez-dgt
Copy link

This problem happens when you have product and category with the same url key.

Example:

1.- Create Category: Energy Products(URL Key:energy-products)
2.- Create Sub Category Category: Stacker 2 Energy Shots(URL Key:stacker-2-energy-shots)
3.- Create Grouped Product: Stacker 2 Energy Shots(URL Key:stacker-2-energy-shots)
4.- Add Product "Stacker 2 Energy Shots" to Category "Energy Products" for example

Error: URL key for specified store already exists.
image

image

@quienti
Copy link
Contributor

quienti commented Sep 21, 2016

I can confirm, same problem on Magento 2.1.1

@sanjayjethva
Copy link
Author

sanjayjethva commented Sep 22, 2016

Hello @mgomez-dgt
Thanks for your answer but problem still exist if i can change the category url or name to say "test" or "demo". I am choosing random name but still it displays same error.
I am facing the issue when i change category name.

Thanks and let me know

@sumitgithub
Copy link

same problem while updating an product with category changes

@janmyszkier
Copy link

janmyszkier commented Oct 5, 2016

Similiar problem here, but touches product-category relations. Removing product-category assignment allows you to save the product without having "URL key for specified store already exists." (but of course is not desirable for any store owners out there).
If it helps anyone debugging this this is the URL Rewrites that didn't allow me to add product unless categories were unassigned:

mysql> select * from url_rewrite\G;
*************************** 1. row ***************************
  url_rewrite_id: 1
     entity_type: cms-page
       entity_id: 1
    request_path: no-route
     target_path: cms/page/view/page_id/1
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 2. row ***************************
  url_rewrite_id: 2
     entity_type: cms-page
       entity_id: 2
    request_path: home
     target_path: cms/page/view/page_id/2
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 3. row ***************************
  url_rewrite_id: 3
     entity_type: cms-page
       entity_id: 3
    request_path: enable-cookies
     target_path: cms/page/view/page_id/3
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 4. row ***************************
  url_rewrite_id: 4
     entity_type: cms-page
       entity_id: 4
    request_path: privacy-policy-cookie-restriction-mode
     target_path: cms/page/view/page_id/4
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 5. row ***************************
  url_rewrite_id: 242
     entity_type: product
       entity_id: 14
    request_path: /red-wine/testingadmin-simple.html
     target_path: catalog/product/view/id/14/category/11
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 0
        metadata: a:1:{s:11:"category_id";s:2:"11";}
*************************** 6. row ***************************
  url_rewrite_id: 263
     entity_type: category
       entity_id: 6
    request_path: whiskey.html
     target_path: catalog/category/view/id/6
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 7. row ***************************
  url_rewrite_id: 264
     entity_type: category
       entity_id: 8
    request_path: whiskey/.html
     target_path: catalog/category/view/id/8
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 8. row ***************************
  url_rewrite_id: 265
     entity_type: category
       entity_id: 6
    request_path: .html
     target_path: catalog/category/view/id/6
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 9. row ***************************
  url_rewrite_id: 266
     entity_type: category
       entity_id: 8
    request_path: whiskey/.html
     target_path: catalog/category/view/id/8
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 10. row ***************************
  url_rewrite_id: 351
     entity_type: product
       entity_id: 28
    request_path: wine.html
     target_path: catalog/product/view/id/28
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 11. row ***************************
  url_rewrite_id: 352
     entity_type: product
       entity_id: 28
    request_path: wine.html
     target_path: catalog/product/view/id/28
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 12. row ***************************
  url_rewrite_id: 447
     entity_type: product
       entity_id: 45
    request_path: 1.html
     target_path: catalog/product/view/id/45
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 13. row ***************************
  url_rewrite_id: 448
     entity_type: product
       entity_id: 45
    request_path: 1.html
     target_path: catalog/product/view/id/45
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 14. row ***************************
  url_rewrite_id: 485
     entity_type: product
       entity_id: 51
    request_path: 5.html
     target_path: catalog/product/view/id/51
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 15. row ***************************
  url_rewrite_id: 486
     entity_type: product
       entity_id: 51
    request_path: 5.html
     target_path: catalog/product/view/id/51
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 16. row ***************************
  url_rewrite_id: 487
     entity_type: product
       entity_id: 52
    request_path: 6.html
     target_path: catalog/product/view/id/52
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 17. row ***************************
  url_rewrite_id: 488
     entity_type: product
       entity_id: 52
    request_path: 6.html
     target_path: catalog/product/view/id/52
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 18. row ***************************
  url_rewrite_id: 489
     entity_type: product
       entity_id: 53
    request_path: 7.html
     target_path: catalog/product/view/id/53
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 19. row ***************************
  url_rewrite_id: 490
     entity_type: product
       entity_id: 53
    request_path: 7.html
     target_path: catalog/product/view/id/53
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 20. row ***************************
  url_rewrite_id: 491
     entity_type: product
       entity_id: 54
    request_path: 8.html
     target_path: catalog/product/view/id/54
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 21. row ***************************
  url_rewrite_id: 492
     entity_type: product
       entity_id: 54
    request_path: 8.html
     target_path: catalog/product/view/id/54
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 22. row ***************************
  url_rewrite_id: 493
     entity_type: product
       entity_id: 55
    request_path: 888.html
     target_path: catalog/product/view/id/55
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 23. row ***************************
  url_rewrite_id: 494
     entity_type: product
       entity_id: 55
    request_path: 888.html
     target_path: catalog/product/view/id/55
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 24. row ***************************
  url_rewrite_id: 495
     entity_type: cms-page
       entity_id: 5
    request_path: test-article
     target_path: cms/page/view/page_id/5
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 25. row ***************************
  url_rewrite_id: 496
     entity_type: cms-page
       entity_id: 5
    request_path: test-article
     target_path: cms/page/view/page_id/5
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 26. row ***************************
  url_rewrite_id: 567
     entity_type: category
       entity_id: 19
    request_path: root-catalog.html
     target_path: catalog/category/view/id/19
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 27. row ***************************
  url_rewrite_id: 568
     entity_type: category
       entity_id: 19
    request_path: root-catalog.html
     target_path: catalog/category/view/id/19
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 28. row ***************************
  url_rewrite_id: 258507
     entity_type: product
       entity_id: 72
    request_path: some-testing-product.html
     target_path: catalog/product/view/id/72
   redirect_type: 0
        store_id: 2
     description: NULL
is_autogenerated: 1
        metadata: NULL
*************************** 29. row ***************************
  url_rewrite_id: 258508
     entity_type: product
       entity_id: 72
    request_path: some-testing-product.html
     target_path: catalog/product/view/id/72
   redirect_type: 0
        store_id: 1
     description: NULL
is_autogenerated: 1
        metadata: NULL
29 rows in set (0.00 sec)

It seems like there's something wrong with category update mechanism.

I went ahead saving categories one by one and pinpointed the troubling category to:
/catalog/category/edit/id/10/

and seen there's really no url in database so made it:

insert into url_rewrite VALUES (NULL,'category',10,'wines.html','catalog/category/view/id/10',0,1,NULL,1,NULL);
insert into catalog_category_entity_varchar VALUES (NULL,117,0,10,'wines'); (117 - url_key)
insert into catalog_category_entity_varchar VALUES (NULL,118,0,10,'wines'); (118 - url_path)

then run:
php bin/magento indexer:reindex

now the url would appear in the admin edit form but of course still after trying to save it:
URL key for specified store already exists.

I went ahead and added url keys manually to the DB and updated url_rewrite manually aswell. still can't save that product with categories assigned...

We need to go deeper then....
In vendor/magento/module-url-rewrite/Model/Storage/AbstractStorage.php
added some additional info:

throw new \Magento\Framework\Exception\AlreadyExistsException(
                __('URL key for specified store already exists - '.$e->getMessage() )
            );

and that got me the error I needed:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '/testing-products.html-2' for key 'URL_REWRITE_REQUEST_PATH_STORE_ID', query was: INSERT INTOurl_rewrite(redirect_type,is_autogenerated,metadata,description,entity_type,entity_id,request_path,target_path,store_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?), (?, ?, ?, ?, ?, ?, ?, ?, ?)
wait what? I already fixe duniqueness of my urls....

Considering the result of
show index from url_rewrite where non_unique = 0\G; that says we only make use of target_path and store_id I stripped the data the app is trying to insert:

array (
  0 => 
  array (
    'request_path' => 'testing-products.html',
    'target_path' => 'catalog/product/view/id/84',
    'store_id' => '2',
  ),
  1 => 
  array (
    'request_path' => 'wines/testing-products.html',
    'target_path' => 'catalog/product/view/id/84/category/10',
    'store_id' => '2',
  ),
  2 => 
  array (
    'request_path' => '/testing-products.html',
    'target_path' => 'catalog/product/view/id/84/category/1',
    'store_id' => '2',
  ),
  3 => 
  array (
    'request_path' => '/testing-products.html',
    'target_path' => 'catalog/product/view/id/84/category/2',
    'store_id' => '2',
  ),
  4 => 
  array (
    'request_path' => 'testing-products.html',
    'target_path' => 'catalog/product/view/id/84',
    'store_id' => '1',
  ),
  5 => 
  array (
    'request_path' => 'wines/testing-products.html',
    'target_path' => 'catalog/product/view/id/84/category/10',
    'store_id' => '1',
  ),
  6 => 
  array (
    'request_path' => '/testing-products.html',
    'target_path' => 'catalog/product/view/id/84/category/1',
    'store_id' => '1',
  ),
  7 => 
  array (
    'request_path' => '/testing-products.html',
    'target_path' => 'catalog/product/view/id/84/category/2',
    'store_id' => '1',
  ),
)

So the problem seems to be in categories 1 & 2 which, through the admin panel, I cannot update url keys for. And that leads us to some hints for why custom imports fail here and why shop, where the customer accidentally removed his root category (which was later readded) fails.

Edit: dirty fix is changing
vendor/magento/module-url-rewrite/Model/Storage/DbStorage.php
from

    protected function doReplace($urls)
    {
        foreach ($this->createFilterDataBasedOnUrls($urls) as $type => $urlData) {
            $urlData[UrlRewrite::ENTITY_TYPE] = $type;
            $this->deleteByData($urlData);
        }
        $data = [];
        foreach ($urls as $url) {
            $data[] = $url->toArray();
        }
        $this->insertMultiple($data);
    }

into

    protected function doReplace($urls)
    {
        foreach ($this->createFilterDataBasedOnUrls($urls) as $type => $urlData) {
            $urlData[UrlRewrite::ENTITY_TYPE] = $type;
            $this->deleteByData($urlData);
        }
        $data = [];
        foreach ($urls as $url) {
            $data[] = $url->toArray();
        }

         /* FIXME: Get rid of rewrite for root Magento category to unduplicate things
          * @see: https://github.com/magento/magento2/issues/6671 */
        foreach($data as $key =>$info){
                if(isset($info['target_path']) && stristr($info['target_path'],'/category/1') && $info['entity_type']=='product'){
                        unset($data[$key]);
                }
        }

        $this->insertMultiple($data);
    }

M2 team: please fix root category handling and that should fix those.

@janmyszkier
Copy link

@miakusha ☝️ there's your update ;)

@frostshoxx
Copy link

frostshoxx commented Oct 31, 2016

I'm having the same issue as well. Is it being fixed, so should I just do the dirty fix to get the ball rolling?

I tried to update DbStorage.php per @janmyszkier recommendation, but the error URL key for specified store already exists. still thrown after I tried to update the category name.

@jameshalsall
Copy link

Can confirm this is happening with 2.1.2 EE as well.

@jameshalsall
Copy link

@frostshoxx it's like your root category has a different ID than the one in @janmyszkier's example code

@kanduvisla
Copy link
Contributor

kanduvisla commented Nov 3, 2016

Confirmed in M2.1.2

I have 2 categories that have similar sub-category names (For example foo/bar, goo/bar). 'bar' is considered a duplicate key.

Fun fact: truncating the url_rewrite table did solve the problem for me.

@jameshalsall
Copy link

I managed to fix this in the end, I would recommend not emptying your url_rewrite table.

We had multiple stores, and products from store A were associated to categories under store B. At a high level this is what I can tell was happening:

  • Store A had category X with multiple products
  • Store B had product Y that was somehow added to category X in Store A
  • When Magento generates category level rewrites, it goes through every product in each store's category. It found product Y in category X and generated a product level rewrite for it (this is wrong, because the product was not available in Store A)
  • When Magento then tries to generate product level rewrites it attempts to generate the product level rewrite for product Y again it hits the "URL key for specified store already exists" error, because in the previous step it had been generated already.

@frostshoxx
Copy link

@jameshalsall How did you manage to fix this issue in the end?

@quynhvv
Copy link

quynhvv commented Nov 4, 2016

Hi guys,

Let's try with a workaround in reply from @quynhvv in here:
#7298

Regards,
Mall.

@janmyszkier
Copy link

👎 for @magento-team for leaving this issue unresolved for so long with not even a workaround.

@jameshalsall
Copy link

jameshalsall commented Nov 4, 2016

@frostshoxx I removed the associations of products to categories that were cross-store, if that makes sense.

EDIT: I think this could be a problem with the save + duplicate feature, when you're editing a product from one store and then duplicate it to the other store it may keep the category associations from the original store.

@pavelshulga
Copy link

The url regeneration process is large/implicit and complex to keep all the main entities in e-commerce industry (products and categories) accessible to customers.

Flow

The flow is next:

  • category entity itself is processed and all the changes are saved to DB (in terms of active transaction)
  • then afterSave event is dispatched (this event is dispatched to any entity in Magento 2 if child of AbstractModel)
  • urlProcessing is run according to observer configuration in Magento_CatalogUrlRewrite module:
<event name="catalog_category_save_after">
    <observer name="process_url_rewrite_saving" instance="Magento\CatalogUrlRewrite\Observer\CategoryProcessUrlRewriteSavingObserver"/>
</event>
  • process generates canonical category URL rewrite
  • the process runs through all the products (direct child products as well as products in subcategories)
  • process generates current URL rewrites (301 redirects)
  • process generates anchor URL rewrites
  • then all generated rewrites is combined into one array via array_merge
  • process generates one INSERT query with generated rewrites as binding for it
  • logically process running the query execution

Actual problem

The error shown on frontend is "URL key for specified store already exists." but actual error message which is generated by DB engine is next:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '[SOME_URL_PATH]' for key 'URL_REWRITE_REQUEST_PATH_STORE_ID'

Used environment

Environment is next:

  • Magento EE 2.1.2
  • Apache/nginx

Causes explanation

The problem is caused by using of array_merge (1st) for combining all the url rewrites generated and by anchor URL rewrites generation procedure (2nd):

  • before array_merge
    before array_merge
  • after array_merge
    after array_merge

Second is using categoryRepository in internals for obtaining category objects which opens a possibility to use inconsistent/outdated data and first one makes it possible to overwrite correctly generated data with wrong data from anchor URL generation.

In our case the problem was and still is with product rome-umbrella-lane which belonds to the category women's accessories (URL key is womes-s-accessories). When the user fills new url_path (women-accessories) the the whole process is run and during the anchor generation one products category is in fact child category for edited one:
vendor/magento/module-catalog-url-rewrite/Model/ProductUrlRewriteGenerator.php

protected function generateForSpecificStoreView($storeId, $productCategories)
...
$urls = array_merge(
            $this->canonicalUrlRewriteGenerator->generate($storeId, $this->product),
            $this->categoriesUrlRewriteGenerator->generate($storeId, $this->product, $this->productCategories),
            $this->currentUrlRewritesRegenerator->generate($storeId, $this->product, $this->productCategories),
            $this->getAnchorUrlRewriteGenerator()->generate($storeId, $this->product, $this->productCategories)
        );
...

scarves category is child of women-s-accessories and parent category is marked as anchor:
vendor/magento/module-catalog-url-rewrite/Model/Product/AnchorUrlRewriteGenerator.php

public function generate($storeId, Product $product, ObjectRegistry $productCategories)
...
$anchorCategoryIds = $category->getAnchorsAbove();
            if ($anchorCategoryIds) {
                foreach ($anchorCategoryIds as $anchorCategoryId) {
                    //TODO add check is anchored category is edited category and url_path updated
                    $anchorCategory = $this->categoryRepository->get($anchorCategoryId);
...

In $this->categoryRepository->get($anchorCategoryId) category object is fetched from cache:
vendor/magento/module-catalog/Model/CategoryRepository.php

/**
     * {@inheritdoc}
     */
    public function get($categoryId, $storeId = null)
    {
        $cacheKey = null !== $storeId ? $storeId : 'all';
        //if (!isset($this->instances[$categoryId][$cacheKey])) {
            /** @var Category $category */
            $category = $this->categoryFactory->create();
            if (null !== $storeId) {
                $category->setStoreId($storeId);
            }
            $category->load($categoryId);
            if (!$category->getId()) {
                throw NoSuchEntityException::singleField('id', $categoryId);
            }
            $this->instances[$categoryId][$cacheKey] = $category;
        //}
        return $this->instances[$categoryId][$cacheKey];
    }

Problem cause

product is assigned directly to edited category (while editing url_key) and assigned to one of child category and edited category marked as anchor.

Options of resolving for Magento Team

The solution is not clear at first glance but there are few options:

  • get rid of cache usage for urlGeneration (can affect the time and speed drastically)
  • add a feature to flush category cache directly before urlGeneration procedure (will not affect the speed dramatically but for now categoryRepository doesn't have a feature to flush protected _instances field)

Options for us until Magento 2 release

One of the options which is available for client project developers - apply complex solution with few rewrites via preference for categoryRepository to add instances cache invalidation method and anchorURLRewriteGeneration with usage of added method but obviously this isn't recommended at all bc can affect different parts of the functionality.

Hope this will help to fix this issue finally.

@maderlock
Copy link

Currently I'm patching these issues (incorrect anchor URLs and not generating URLs for multiple stores) by:

  1. Replacing $storeId=$category->getStoreId() in module-catalog-url-rewrite/Observer/UrlRewriteHandler.php with $storeId=0. This then works like the category URL generation and iterates over the stores. Just getting the current store only creates (and deletes) links for the current store
  2. Commenting out $this->getAnchorUrlRewriteGenerator()->generate($storeId, $this->product, $this->productCategories) in module-catalog-url-rewrite/Model/ProductUrlRewriteGenerator.php as I have yet to find the situation where this is actually needed.

Obviously I now need to make these into plugins or preferences, but can anyone see a problem with these fixes?

@maderlock
Copy link

After my changes the errors go away in some cases. Still getting the error sometimes. Trying to track down exactly when.

@kanduvisla
Copy link
Contributor

I'm trying it local now as well. But the weird part is: earlier, when I truncated the url_rewrite-table, the problem was gone, but now when I truncate the table and re-save the category I get the same error. I've looked in the database and there are no other categories that share the same URL key.

@janmyszkier
Copy link

@kanduvisla if you look at the example you'll see that I didn't have them either and the error was there because it tried to INSERT them (which failed). not because they were already in the database.

@basselalaraaj
Copy link

basselalaraaj commented Nov 17, 2016

i was getting the same error, i fixed mine by removing duplicated data from the product url-keys.
What i saw was, that i had 2 or more products with the same url-key, under the same categorie.

@PascalBrouwers
Copy link
Contributor

I tried the fix mentioned by janmyszkier. At first I could save the category. On a second save I get the error again :(

cpartica pushed a commit that referenced this issue Jul 14, 2017


- display original DB error in case conflicting URLs are not found
cpartica pushed a commit that referenced this issue Jul 14, 2017
[Jackalopes] [Okapis] Combined PR

- MAGETWO-66480 [GITHUB] URL key for specified store already exists #6671
- MAGETWO-67296 String localization is not working when phrase contains quote (')
- MAGETWO-69657 Credit Card Information disappear after user enters promotion code
- MAGETWO-63249 [Elasticsearch] Composite products not searchable
@Koc
Copy link

Koc commented Jul 17, 2017

@cpartica @buskamuza can you backport fix for this issue to 2.1.x branch also?

@buskamuza
Copy link
Contributor

@Koc , there is an internal ticket for it as mentioned above. Unfortunately, I can't say anything about time line as it should be prioritized.

@nntoan
Copy link
Contributor

nntoan commented Jul 21, 2017

@cpartica Can you provide a patch for 2.1.x ? Or backport it into 2.1.8 ?

@toan-tam
Copy link

Hi guys,

Let's try my solutions issue #7298.

Hope this help.
Thanks.

@christopher-s
Copy link

@cpartica I would also like to see a patch that we can apply to 2.1.x. This issue is causing no end of grief for my client's ecommerce site.

@dharake
Copy link

dharake commented Jul 23, 2017 via email

@niners52
Copy link

Has anyone figured out how to apply MAGETWO-66480 to 2.1.7?

@christopher-s
Copy link

@dverkade I notice you have a pull request to fix this here:
#10356

Is that applicable to v2.1.x?

@dverkade
Copy link
Member

dverkade commented Aug 2, 2017

Hey @christopher-s,

We have created the changes as core fixes for ourselfs and then reworked those to create the PR. There is some difference in the way the URL rewrites are handled between Magento 2.1 and 2.2 so the code is a bit different, but you can look at my changes in the PR and create a solution for Magento 2.1 from it if you like. Please upvote / like the PR, because there is quite a discussion going on and I think the more people agree with the changes and get involved with the discussion will convince the core team to look at this more seriously.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Component: CatalogUrlRewrite Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@joaoasrosa
Copy link

@dverkade the fix is included in the latest version (2.1.9)?

@spyrule
Copy link

spyrule commented Sep 15, 2017

Its not posted as a fix in 2.1.9 KB, and it just failed G1 testing by the engineering team. So I'd say no.

@magento-engcom-team
Copy link
Contributor

@sanjayjethva, thank you for your report.
The issue is already fixed in 2.2.0

@magento magento locked and limited conversation to collaborators Sep 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug report Component: CatalogUrlRewrite Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests