Few weaknesses in the code

[AppChecker]

Hi!

I hope this will be helpful:

app/code/Magento/Usps/Model/Carrier.php

        if ($response === false || $response->getName() == 'Error') {
            $debugData['result'] = [
                'error' => $response->Description,
                'code' => $response->Number,
                'xml' => $response->asXML(),
            ];
...
        }

if $response is false, method asXML will be called on false

app/code/Magento/CatalogSearch/Model/Layer/Filter/Decimal.php

$label = $this->renderRangeLabel(
                empty($from) ? 0 : $from,
                empty($to) ? $to : $to
            );

Both parts of ternary operators are equals.

app/code/Magento/CatalogRule/Model/Rule.php

if (is_array($value)) {
                    if ($value != $array2[$key]) {
                        $result[$key] = true;
                    }
                } else {
                    if ($value != $array2[$key]) {
                        $result[$key] = true;
                    }
                }

Parts of if-conditional operator are equals.

Possible defect was found by Echelon team with AppChecker static analyzer

[veloraven]

@AppChecker thank you for your feedback.
Please identify which version of Magento you are running.
Please create a separate issue for each problem and format them according to the Issue reporting guidelines

[vzabaznov]

internal ticket created MAGETWO-62187

[vzabaznov]

issue was fixed in fresh magento, thanks for reporting

[magento-engcom-team]

Hi @AppChecker. Thank you for your report.
The issue has been fixed in #21968 by @Nazar65 in 2.3-develop branch
Related commit(s):

• 7cb0cf8dc21612761b9e58de600447c12ef340dd
• bbe71ef43062429cd3f235ad885cc3a996e7628d

The fix will be available with the upcoming 2.3.2 release.

[magento-engcom-team]

Hi @AppChecker. Thank you for your report.
The issue has been fixed in #22453 by @Nazar65 in 2.2-develop branch
Related commit(s):

• 34b2dccf322c1af0d5c563063e439de1b4a9cbe9

The fix will be available with the upcoming 2.2.9 release.