Product Repository saves attribute values for existing product always on "Default Store Level"

[itaymesh]

Preconditions

1. Magento 2.1.2
2. PHP 7
3. Mysql 5.6

Steps to reproduce

1. Create a CLI command to create/update a production
2. Execute the comment (new product)
3. Execute the comment (update product)

Expected result

1. New Product: values are saved on "All Store Views"
2. Update Product: values are saved on "All Store Views"

Actual result

1. New Product: values are saved on "All Store Views"
2. Update Product: values are saved on "Default Store View"

Seems like the product repository class overrides the product store id and always assign default store id

app/code/Magento/Catalog/Model/ProductRepository.php#L530

$productDataArray['store_id'] = (int)$this->storeManager->getStore()->getId();

The only way to work around this issue is by getting the existing product with explicit parameter:
$product = $this->_productRepository->get($sku, true, 0);

and use the deprecated save method of Magento\Framework\Model\AbstractModel class at line 629.

[mattcoz]

This is driving me crazy. Updating a product in the backend always saves attributes with store_id of 0 and then on the frontend it looks up attributes using store_id of 1. So the only way to update anything is to do so directly in the database. This is with single store mode enabled, which should mean that there should only be ONE store not two.

[leitot]

I have this issue as well. I fixed it with a hack but is something going to be done about this?

[p3mbo]

I can confirm that this is an issue for me too still. Magento 2.1.6

[mattcoz]

What kind of hack did you use? This is really a debilitating issue and the developers don't seem to care at all. - Matt

…

On Mar 27, 2017 2:24 PM, "leitot" ***@***.***> wrote: I have this issue as well. I fixed it with a hack but is something going to be done about this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7720 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUf75koyoYhVYhjfucIs3xidcrCeJxHks5rp_uNgaJpZM4LHJ7x> .

[leitot]

I wrote a before plugin for the save() method for the type Magento\Catalog\Model\ResourceModel\Product. Inside beforeSave() I set the store ID correctly on the product (after the ProductRepository's save() method messes it up)

[mattcoz]

Thanks, I'll give that a shot. I have the same problem with the category repository too. - Matt On May 22, 2017 9:03 PM, "leitot" <notifications@github.com> wrote: I wrote a before plugin for the save() method for the type Magento\Catalog\Model\ResourceModel\Product. Inside beforeSave() I set the store ID correctly on the product (after the ProductRepository's save() method messes it up) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7720 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUf75oBD3hoHTgjSLK6Qrr9hU7PmiZoks5r8j5bgaJpZM4LHJ7x> .

[cherreman]

I have this issue in CE 2.1.7.

The save method in the ProductRepository is incorrectly setting the store_id property on the product.

The fix is to check if the store_id is already set on the product, and if not, set it. Add the if-statement around the line below:

if (!isset($productDataArray['store_id'])) {
    $productDataArray['store_id'] = (int)$this->storeManager->getStore()->getId();
}

[magento-engcom-team]

@itaymesh, thank you for your report.
We've created internal ticket(s) MAGETWO-83254 to track progress on the issue.

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-30488 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

Hi @itaymesh. Thank you for your report.
The issue has been fixed in #26470 by @engcom-Charlie in 2.4-develop branch
Related commit(s):

• 042df4153f29e6dfb18604ac0ca72c4a0671ef58
• a039ff41d4938d06e507778aaac4983e12ae8421
• 13af48ab3e53f9ec4d2d29dec28d39cffd7c9e3b
• a5d735597be47651535f1504d4e2a67377996a1c
• 8c8949db53c3eac5bf328889b72c0da01afc0b2b
• 2c155171b27da618df84c123c3aa9312f7ccd0bb
• 156b3c285baba8df7ec04853746fbf44e8ed6d83
• 347001fe941d4e2c3ce46926fa75d77f52037037
• 28b5d9d59803825e0bc9e340716cd269c7e26b6a
• a892a197f9a0a4b5f61af65ca0a71dca425caf7e
• 9b9d12351b679d72987d7f6799d07a1faa9cf216

The fix will be available with the upcoming 2.4.2 release.