magento/magento2#7720

[engcom-Charlie]

Description (*)

Product repository now uses store_id if it is set.

Fixed Issues (if relevant)

1. Product Repository saves attribute values for existing product always on "Default Store Level" #7720: Product Repository saves attribute values for existing product always on "Default Store Level"

Manual testing scenarios

1. Create a Product, save it via ProductRepository::save.
2. Load the Product via ProductRepository::get, pass 0 as storeId parameter.
3. Save the Product via ProductRepository::save once more.
4. Make sure catalog_product_entity_* tables contain only records with store_id=0.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[Nazar65]

Hi @engcom-Charlie , please see my review comments, also fix the static tests

[lbajsarowicz]

Some minor changes to cover the change.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6698 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Hotel]

✔️ QA Passed

[sidolov]

@engcom-Charlie could you please resolve merge conflicts?

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

Hi @sidolov, I've done it.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-6698 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create a Product, save it via ProductRepository:save ("Simple" for ex.);
2. Load the Product via ProductRepository::get, pass 0 as storeId parameter;
3. Save the Product via ProductRepository::save once more. (update Product name for ex.: "Simple (Updated)");
4. Make sure catalog_product_entity_* tables contain only records with store_id=0.

Before: ✖️ Table catalog_product_entity_int contain records with store_id=0 and store_id=1

✖️ and product name updated for Default Store View (store_id=1)

After: ✔️ catalog_product_entity_int table contain only records with store_id=0

✔️ and product name updated for All Store Views (store_id=0)

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.