Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customer_account.xml file abused #7816

Closed
LiamFielding opened this issue Dec 15, 2016 · 12 comments
Closed

Customer_account.xml file abused #7816

LiamFielding opened this issue Dec 15, 2016 · 12 comments
Assignees
@mikewhitby @PieterCappelle
Labels
Event: distributed-cd Distributed Contribution Day Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@LiamFielding
Copy link

From the Magento Paypal module, this is added in its customer_account.xml file:

<head>
    <title>Billing Agreements</title>
</head>

This is very unwise since the benefit of having the customer_account is that all the pages on there use it to update for the convenience of getting all of the dashboard links and updates.

After adding another page to the route, we now have to awkwardly remove what isn't even page.main.title.

I consider this an issue, I hope others feel the same way.
@veloraven
Copy link
Contributor

@LiamFielding thank you for your feedback.
Please format description according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result if you think it to be an issue. Please, also identify which version of Magento you are running.
You can also submit it to the new Magento 2 Feature Requests and Improvements forum (see details here) as it rather looks like an improvement.

@veloraven
Copy link
Contributor

According to contributor guide, tickets without response for two weeks should be closed.
If this issue still reproducible please feel free to create the new one: format new issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result and specify Magento version.

@PieterCappelle
Copy link
Contributor

@veloraven Can you please reopen this issue and assign it to me. The issue is indeed not correct formated but it is an issue. I'll fix it.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Oct 26, 2017
@orlangur orlangur reopened this Oct 26, 2017
@orlangur
Copy link
Contributor

orlangur commented Oct 26, 2017 •
edited
Loading

@PieterCappelle leaving it Unassigned + needs update, I believe somebody else is adding some OCTOBERFEST labels and assign to contributors.

@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 4, 2017
@magento-engcom-team
Copy link
Contributor

@LiamFielding, thank you for your report.
We've created internal ticket(s) MAGETWO-84985 to track progress on the issue.

@PieterCappelle PieterCappelle mentioned this issue Dec 21, 2017
Merged
4 tasks
@PieterCappelle
Copy link
Contributor

PieterCappelle commented Dec 21, 2017 •
edited
Loading

Created PR for 2.3-develop branch. If accepted I'll create backport for 2.2-develop & 2.1-develop branch.

@magento-team
Copy link
Contributor

Hi @LiamFielding. Thank you for your report.
The issue has been fixed in #12852 by @PieterCappelle in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 9, 2018
@magento-engcom-team magento-engcom-team added the Event: distributed-cd Distributed Contribution Day label Mar 19, 2018
@mikewhitby
Copy link
Contributor

I'm working on the backport #distributed-cd

@magento-engcom-team
Copy link
Contributor

@mikewhitby thank you for joining. Please accept team invitation here and self-assign the issue.

@mikewhitby mikewhitby self-assigned this Mar 24, 2018
mikewhitby added a commit to mikewhitby/magento2 that referenced this issue Mar 24, 2018
@mikewhitby
magento#7816: Customer_account.xml file abused
caf5b3e 
This is in addiiton to magento#12852 commit 36cac17 - that fix
removed the title from being set in the `customer_account.xml` file but
the fix seemed to do nothing as the title was always being set in the
controller anyway. I've removed from the controller and added to the
correct layout file.
mikewhitby added a commit to mikewhitby/magento2 that referenced this issue Mar 24, 2018
@mikewhitby
magento#7816: Customer_account.xml file abused
4f30a3c 
This is in addiiton to magento#12852 commit 36cac17 - that fix
removed the title from being set in the `customer_account.xml` file but
the fix seemed to do nothing as the title was always being set in the
controller anyway. I've removed from the controller and added to the
correct layout file.
mikewhitby added a commit to mikewhitby/magento2 that referenced this issue Mar 24, 2018
@mikewhitby
magento#7816: Customer_account.xml file abused
09f8059 
This is in addiiton to magento#12852 commit 36cac17 - that fix
removed the title from being set in the `customer_account.xml` file but
the fix seemed to do nothing as the title was always being set in the
controller anyway. I've removed from the controller and added to the
correct layout file.
This was referenced Mar 24, 2018
Merged
Merged
Merged
@magento-engcom-team
Copy link
Contributor

Hi @LiamFielding. Thank you for your report.
The issue has been fixed in #14325 by @mikewhitby in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 28, 2018
magento-engcom-team added a commit that referenced this issue Mar 28, 2018
@magento-engcom-team
ENGCOM-1063: #7816: Customer_account.xml file abused (2.2) #14325
8529a73 
 - Merge Pull Request #14325 from mikewhitby/magento2:fix_7816_2.2
 - Merged commits:
   1. 56b3598
   2. 09f8059
magento-engcom-team pushed a commit that referenced this issue Mar 28, 2018
ENGCOM-1063: #7816: Customer_account.xml file abused (2.2) #14325
25620e9
@sidolov
Copy link
Contributor

sidolov commented Mar 30, 2018

Hi @LiamFielding. Thank you for your report.
The issue has been fixed in #14322 by @mikewhitby in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Mar 30, 2018
@magento-engcom-team
ENGCOM-1146: #7816: Customer_account.xml file abused (2.3) #14322
4a34325 
 - Merge Pull Request #14322 from mikewhitby/magento2:fix_7816_2.3
 - Merged commits:
   1. caf5b3e
magento-engcom-team pushed a commit that referenced this issue Mar 30, 2018
ENGCOM-1146: #7816: Customer_account.xml file abused (2.3) #14322
3cf7155
@magento-engcom-team
Copy link
Contributor

Hi @LiamFielding. Thank you for your report.
The issue has been fixed in #14323 by @mikewhitby in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.14 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Mar 30, 2018
magento-engcom-team added a commit that referenced this issue Mar 30, 2018
@magento-engcom-team
ENGCOM-1147: #7816: Customer_account.xml file abused (2.1) #14323
2ea01f6 
 - Merge Pull Request #14323 from mikewhitby/magento2:fix_7816_2.1
 - Merged commits:
   1. 509e5c4
   2. 4f30a3c
magento-engcom-team pushed a commit that referenced this issue Mar 30, 2018
ENGCOM-1147: #7816: Customer_account.xml file abused (2.1) #14323
c100f0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikewhitby mikewhitby

@PieterCappelle PieterCappelle

Labels
Event: distributed-cd Distributed Contribution Day Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@orlangur @mikewhitby @magento-team @veloraven @PieterCappelle @okorshenko @sidolov @LiamFielding @magento-engcom-team