Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable product on wishlist shows parent image instead variation image #8168

Closed
anebi opened this issue Jan 17, 2017 · 9 comments
Closed
Assignees
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@anebi
Copy link

anebi commented Jan 17, 2017

Preconditions

  1. Magento 2.1.3
  2. PHP7
  3. MySQL 5.7.16

Steps to reproduce

  1. Create product from Configurable type with default image
  2. Assign products to this Configurable with let's say color and size attributes. Let the associated products have different images
  3. Go to that configurable product on frontend, select configurations and add the product to wishlist.
  4. Go to wishlist in my account and you will notice that wishlist displays images of parent product instead of the product that represent selected configurations

Expected result

  1. Wishlist should display variation product image instead of parent
  2. Currently this is done for checkout page and cart and we are able to select from backend if we want parent or child product image to be displayed
@Szymon-GP
Copy link

Szymon-GP commented Feb 2, 2017

I have the same issue, if you add different variations they will be listed separately in whishlist but the image is wrong, it represents configurable product rather than specific variation

@KrystynaKabannyk KrystynaKabannyk assigned antboiko and unassigned antboiko Feb 2, 2017
@naydav naydav self-assigned this Feb 6, 2017
@naydav
Copy link
Contributor

naydav commented Feb 7, 2017

Internal ticket MAGETWO-8709 which tracks this GitHub issue, is in our issue backlog.
Thanks

@naydav naydav added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 7, 2017
@naydav naydav removed their assignment Feb 8, 2017
@christian-rizza
Copy link

christian-rizza commented Feb 9, 2017

If someone is interesting to a workaround, I suggest creating a plugin for
Magento\Wishlist\Block\Customer\Wishlist\Item\Column\Image
and write something like:

public function aroundGetImage(
        Image $subject,
        \Closure $proceed,
        Product $product,
        $imageId,
        $attributes
    ) {
        if ($product->getTypeId() == 'configurable') 
        {
            $simpleProduct = $this->productRepository->get($product->getSku());
            $url = $this->config->getBaseMediaUrl() . $simpleProduct->getImage();
            $block = $proceed($product, $imageId, $attributes);
            $block->setImageUrl($url);
            return $block;
        }
        return $proceed($product, $imageId, $attributes);
    }

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@anebi, thank you for your report.
We've created internal ticket(s) MAGETWO-8709 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@RomaKis RomaKis self-assigned this Dec 14, 2017
@RomaKis
Copy link
Contributor

RomaKis commented Dec 15, 2017

Working on this.

@magento-engcom-team
Copy link
Contributor

Hi @anebi. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1031 by @RomaKis in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 24, 2018
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- relying on item from cart as it has a setting in the admin that wishlist should have it too
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- fix section
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- refactoring to consolidate code for both cart and wishlist with a composite class
- removing and deprecating old references
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
…if options are selected for configurable product #8168

-added functional test to cover bug fix
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
…if options are selected for configurable product #8168

-Updated the group value of the functional test
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
…if options are selected for configurable product #8168

-incorporated review comments of CR-MAGETWO-40576
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- fixing unit tests
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- fixing formatting
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- fixing formatting
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- remove unused
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- remove unused
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- adding strict
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- removing object from composite
- removing un-necessary methods
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- fixing formatting
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- fixing formatting
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- adding optimization
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
… if options are selected for configurable product #8168

- make property private
magento-engcom-team pushed a commit that referenced this issue Jul 20, 2018
[honey] MAGETWO-8709: [GITHUB] Child product image should be shown in Wishist if options are selected for configurable product #8168
@cpartica
Copy link
Contributor

Note that this fix is different on 2.3. Wishlist should obey cart image setting from config. Fix will be backported to 2.2 future releases

magento-engcom-team pushed a commit that referenced this issue Aug 3, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 3, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 3, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 3, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 3, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 3, 2018
@dhrumin44
Copy link

dhrumin44 commented Sep 19, 2018

It was fixed in new 2.2.6 release version, Please check it once from here pull/15477.

@codewidsaurav
Copy link

i face this issue in magento 2.4 , in customer > my wishlist --> it shows configurable product image instead of selected variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests