Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special price not showing correct for in future discounts #8375

Closed
henk-hypershop opened this issue Feb 1, 2017 · 7 comments
Closed

Special price not showing correct for in future discounts #8375

henk-hypershop opened this issue Feb 1, 2017 · 7 comments
Labels
bug report Component: Tax Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@henk-hypershop
Copy link

henk-hypershop commented Feb 1, 2017

Precoditions

  • Magento 2.1.3
  • NGINX

I have setup a configurable product with 3 simple products attached.

I would like to give the simple products a discount price, with a special price from date in the future. However, on the frontend the special price is shown. When i go to this product page, i can see that none of the simple products show the discount price.

This seems like an issue to. Has anyone else experienced this problem?
screen shot 2017-02-01 at 21 09 46
screen shot 2017-02-01 at 21 10 08
screen shot 2017-02-01 at 21 10 13

@miakusha
Copy link
Contributor

miakusha commented Feb 6, 2017

Hi @henk-hypershop , thanks for report

We've created internal ticket MAGETWO-64221 to address this issue.

@miakusha miakusha added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 6, 2017
@miakusha miakusha removed their assignment Feb 6, 2017
@henk-hypershop
Copy link
Author

What is the status of this issue?

magento-team pushed a commit that referenced this issue Jun 14, 2017
Fixed issues:
- MAGETWO-61560 Moving all attributes out from 'Advanced Pricing' group causes error
- MAGETWO-64221 [GitHub] Special price does not display correctly for future discounts #8375
- MAGETWO-69185 Unable to create shipping label if Region not specified for shipping origin
@veloraven
Copy link
Contributor

This issue was fixed in develop branch.
Closed.

@korostii
Copy link
Contributor

Hi @veloraven,
Are there any plans to backport this fix?

@batmike
Copy link

batmike commented Jul 17, 2017

@korostii - I just came across this fix so it hasn't been fixed yet in v. 2.1.7. I copied in the change from commit 1ab9b26 to vendor/magento/module-configurable-product/Pricing/Price/LowestPriceOptionsProvider.php and it worked for me.

@henk-hypershop
Copy link
Author

@korostii You should not make changes in your vendor folder.

@korostii
Copy link
Contributor

@batmike, @henk-hypershop,
Yes, please keep in mind everyone that patching vendor is not a robust solution, since the fixes you place this way will get discarded with the very next version of CE you update to, and you'll have to re-apply them all over again!
However, it still by far the fastest end the most low-effort way to go around these (unless it's either okay for you to wait a few months for the official release or you have a friendly neighborhood developer around which can make the override for you on module level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Tax Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants