Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.1-develop] Fix Filter Customer Report Review #11523

Merged
merged 9 commits into from
Oct 26, 2017
Merged

[Backport 2.1-develop] Fix Filter Customer Report Review #11523

merged 9 commits into from
Oct 26, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Oct 17, 2017

Remove where part from SelectCountSql when grid is filtered

Description

When customer is filtered in Reports -> Review -> By Customer, Grid tries to get number of rows but how you add a custom name that concats customer.firstname and customer.lastname and you need remove where from SelectCountSql

Fixed Issues (if relevant)

  1. Customer review report search Bug in 2.1.x, 2.2 #10301: Customer review report search Bug in 2.1.x, 2.2

Manual testing scenarios

  1. Go to Admin
  2. Reports -> Review -> By Customer
  3. Filter customer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio changed the title Filter Customer Report Review 2.1-develop [Backport] Fix Filter Customer Report Review 2.1-develop [Backport] Oct 17, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Oct 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 18, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.1 2.2.x bug report Component: Customer Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 18, 2017
@osrecio
Copy link
Member Author

osrecio commented Oct 20, 2017

@ishakhsuvarov Added test to test functionality of getSelectCountSql

@osrecio osrecio changed the title Fix Filter Customer Report Review 2.1-develop [Backport] [Backport 2.1-develop] Fix Filter Customer Report Review Oct 20, 2017
@ishakhsuvarov
magento#11523: Fix Filter Customer Report Review
b513e51 
 - Integration test updated
@ishakhsuvarov
magento#11523: Fix Filter Customer Report Review
bc6c5ac 
 - Integration test updated
 - Added backport for MAGETWO-53296 to 2.1, as it blocked the flow
@magento-team magento-team merged commit bc6c5ac into magento:2.1-develop Oct 26, 2017
magento-team pushed a commit that referenced this pull request Oct 26, 2017
MAGETWO-82178: Fix Filter Customer Report Review 2.1-develop [Backport]
f493ae6 
#11523
magento-team pushed a commit that referenced this pull request Oct 26, 2017
@ishakhsuvarov
Merge pull request #1626 from magento-engcom/2.1-develop-prs
05bb680 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-82178 Fix Filter Customer Report Review 2.1-develop [Backport] #11523
 - MAGETWO-82762 [Backport 2.1-develop] Dashboard Fix Y Axis for range #11753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Award: test coverage bug report Component: Customer Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@osrecio @magento-team @vkublytskyi @ishakhsuvarov