Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Error While Trying To Load Quote Item Collection Using Magent… #11869

Merged
merged 2 commits into from
Nov 4, 2017
Merged

Resolve Error While Trying To Load Quote Item Collection Using Magent… #11869

merged 2 commits into from
Nov 4, 2017

Conversation

neeta-wagento
Copy link
Contributor

@neeta-wagento neeta-wagento commented Oct 30, 2017

While Getting Collection of Quote Item using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() was throwing Fatal error: Uncaught Error: Call to a member function getStoreId() on null in C:\www\magento2\vendor\magento\module-quote\Model\ResourceModel\Quote\Item\Collection.php:98
because of used of injected class.

Description

I have used injected class \Magento\Quote\Model\ResourceModel\Quote\Item\Option\CollectionFactory's getStoreId() method.

It seems working fine with Load Quote Item Collection using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems()
$quoteItemCollection = $this->quoteItemCollectionFactory->create()->getItems();

Fixed Issues (if relevant)

  1. magento/magento2#<8954>: Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() #8954

  2. . https://github.com/magento/magento2/issues/8954

Manual testing scenarios

  1. ... Inject class Magento\Quote\Model\ResourceModel\QuoteItem\Collection $quoteItemCollectionFactory
  2. ... $quoteItemCollection = $this->quoteItemCollectionFactory->create()->getItems();
    It will return array as expected result.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

…o\Quote\Model\ResourceModel\QuoteItem\Collection::getItems()
Resolve Space Issue
@ishakhsuvarov
Copy link
Contributor

Hi @neeta-wagento
Please sign the CLA with the email associated to the commits.
Also, please consider covering this fix with the test to ensure it's not broken in future.

Thank you

@ishakhsuvarov ishakhsuvarov self-assigned this Oct 30, 2017
@neeta-wagento
Copy link
Contributor Author

Hi @ishakhsuvarov

Would you please assist about "Please sign the CLA with the email associated to the commits." ? How to do that because it shows All checks have passed So that i can complete it from my side.

@vrann vrann self-assigned this Oct 30, 2017
@vrann vrann added this to the October 2017 milestone Oct 30, 2017
@vrann vrann added Release Line: 2.2 2.2.x bug report Component: Checkout Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 30, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit 18ac9e5 into magento:2.2-develop Nov 4, 2017
okorshenko pushed a commit that referenced this pull request Nov 4, 2017
@magento-engcom-team magento-engcom-team added bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report bugfix Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants