Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT 2.2] [BUGFIX] All UI input fields should have maxlength of 255 because of V… #11914

Merged

Conversation

@lewisvoncken
Copy link
Contributor

commented Oct 31, 2017

…VARCHAR maxlength 255 in the database

same as magento-partners/magento2ce#61

Description

When you save an input field in the Admin or Frontend area with a value greater then 255 characters the actual saved data in the database is 255 characters.

Fixed Issues (if relevant)

  1. #6238: Meta description allows too many characters

Manual testing scenarios

  1. Create a Test product
  2. Paste a string with more then 255 characters in the Meta Description or the Name
  3. Now the value is visible but after saving the value will be set to 255 characters

Apply Changes and Now it is possible to only insert 255 characters in the UI input fields

See the following image with the max length of 255 for the value column in the varchar column
image

@okorshenko okorshenko self-assigned this Nov 8, 2017

@okorshenko okorshenko added this to the November 2017 milestone Nov 8, 2017

@okorshenko okorshenko merged commit 7971f9c into magento:2.2-develop Nov 10, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
okorshenko added a commit that referenced this pull request Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.