Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.1-develop] Fix datetime type product that show current date when is empty in grids #12033

Merged
merged 2 commits into from
Nov 24, 2017

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Nov 5, 2017

Description

Backport of PR: Fix datetime type product that show current date when is empty in grids #11636

In the product grid, when a date attribute is listed and the value was empty, the current date was displayed. This was very confusing because I did not know if the value was assigned or not. Now you can see empty cells when is unassigned.

Fixed Issues (if relevant)

datetime type product attribute showing current date #9869

Manual testing scenarios

  1. Create a date type product attribute
  2. assign that product to the required attribute set
  3. you can edit the attribute value in the product edit.
  4. create a new product and simply not assign any value to this attribute.
  5. save product
  6. Now you dont see the current date if is unset.

NOW:
screen shot 2017-10-24 at 08 55 38

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vrann vrann added the mm17es label Nov 5, 2017
@vrann vrann self-assigned this Nov 5, 2017
@vrann vrann added this to the November 2017 milestone Nov 5, 2017
@vrann vrann added Release Line: 2.1 2.2.x bug report Component: Catalog Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 5, 2017
@omiroshnichenko omiroshnichenko self-assigned this Nov 23, 2017
@magento-team magento-team merged commit 8933489 into magento:2.1-develop Nov 24, 2017
magento-team pushed a commit that referenced this pull request Nov 24, 2017
magento-team pushed a commit that referenced this pull request Nov 24, 2017
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-84238: #10765 Export data from grid not adding custom rendered data magento2 #12373
 - MAGETWO-83282: Backport 2.1-develop] Fix datetime type product that show current date when is empty in grids #12033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report bugfix Component: Catalog Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants