-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute folder as an allowed resource #12187
Add attribute folder as an allowed resource #12187
Conversation
Hey, what's holding up this pull request? |
Hi @thaiphan |
@thaiphan Could you please provide more detailed information on manual testing? Here are steps we've been following:
My assumption is that Swatches module may attempt to load the image file directly at some point and fail to do so. |
Hi @ishakhsuvarov, There's another file that you might need to delete: You also might want to see if you are routing images through get.php. Regards, Thai |
@thaiphan |
Hi @thaiphan |
@thaiphan I am closing this PR for now due to inactivity. Thank you for collaboration. |
Description
Swatches aren't yet configured to be an allowed resource so we can't access them when we switch over to use the database file storage system. This change configures swatches to be an allowed resource.
Manual testing scenarios
Contribution checklist