-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible undefined index when caching config data #13649
Fix possible undefined index when caching config data #13649
Conversation
Hi @mimarcel
So Magento is not installed actually? Why need to execute |
@orlangur this occurs when I push to a Magento Cloud environment where Magento was not installed yet, as part of UPDATE: It actually seems that the environment has a Magento instance installed, but I suppose that |
Hi @mimarcel , please, sign CLA, otherwise, we can't process your pull request |
@sidolov , I have troubles signing the license agreement. |
@mimarcel , try to refresh the page few times, sometimes we have issue with CLA page load |
@sidolov, done. |
Hi @mimarcel. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Fix possible undefined index when caching config data.
This replicates as per below steps to replicate.
Manual testing scenarios
request_uri
value for every log message, if the configuration flagdev/log/request_uri
is enabled. The following sub-steps add a new logger processor inMagento_Developer
module:/var/www/temp/magento2/app/code/Magento/Developer/etc/di.xml
the following content under<config>
tag:/var/www/temp/magento2/app/code/Magento/Developer/Logger/Processor.php
with the following content:Expected
Command
setup:di:compile
is successful.Actual
Command
setup:di:compile
is not successful.The following error occurs:
Note that valid code added in the previous steps does trigger the above error. The exception trace contains line:
Explanation
The error occurs because at this step of loading config data, there are no stores and no websites since Magento is not installed. As a consequence, config data does not contain any store-specific or website-specific configurations.
Contribution checklist