[Forwardport] Fix possible undefined index when caching config data #17551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#13649
Description
Fix possible undefined index when caching config data.
This replicates as per below steps to replicate.
Manual testing scenarios
request_uri
value for every log message, if the configuration flagdev/log/request_uri
is enabled. The following sub-steps add a new logger processor inMagento_Developer
module:/var/www/temp/magento2/app/code/Magento/Developer/etc/di.xml
the following content under<config>
tag:/var/www/temp/magento2/app/code/Magento/Developer/Logger/Processor.php
with the following content:Expected
Command
setup:di:compile
is successful.Actual
Command
setup:di:compile
is not successful.The following error occurs:
Note that valid code added in the previous steps does trigger the above error. The exception trace contains line:
Explanation
The error occurs because at this step of loading config data, there are no stores and no websites since Magento is not installed. As a consequence, config data does not contain any store-specific or website-specific configurations.
Contribution checklist