Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8333: Use Design to get theme, because theme is changed after constr… #13713

Closed
wants to merge 1 commit into from

Conversation

kirmorozov
Copy link
Member

Description

Functionality helps of custom theme per product allows to rollout new theme partially.
But it was broken for some reason.

Solution is applied in production as a patch for 2.2.2.

Fixed Issues (if relevant)

  1. Magento v2.1.2 - Choosing a child theme for product page #8333: Magento v2.1.2 - Choosing a child theme for product page
  2. Custom theme doesn't apply XML layout updates when applied to a product #7710: Custom theme doesn't apply XML layout updates when applied to a product
  3. Category design / theme update not inheriting correctly on product pages #7503: Category design / theme update not inheriting correctly on product pages

Manual testing scenarios

  1. Go to product in admin
  2. Change theme, save.
  3. Selected theme must apply in full

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

Hi @kirmorozov, change looks good to me at first glance, didn't check the logic deeply yet. Would be really nice to cover such case with integration test so that it will be never broken again.

@sidolov
Copy link
Contributor

sidolov commented Mar 27, 2018

Hi @kirmorozov , please, take a look to failed tests

@orlangur orlangur self-assigned this Mar 28, 2018
@okorshenko okorshenko modified the milestones: March 2018, April 2018 Apr 16, 2018
@okorshenko okorshenko modified the milestones: April 2018, May 2018 May 18, 2018
@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@orlangur orlangur added this to the Release: 2.3.0 milestone Jun 26, 2018
@orlangur
Copy link
Contributor

@kirmorozov, closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.

@orlangur orlangur closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants