-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Description
I was looking to open this issue, but thought I'd try and find one before I did. I think this issue is linked to #7503, but is manifesting is achieved in a different way
We have a theme that does not inherit, and it's XML updates appear to be ignored.
Preconditions
Magento 2.1.2, PHP 5.6.24
Environment: Windows XAMPP / Windows WSL
Developer Mode
Steps to reproduce
Set the theme for a specific storeview to Purenet/Theme (our default theme for the store) via Content > Design > Configuration > Edit.
Create and install a theme that has no inheritence. Add layout changes. For this example, I created a theme with a catalog_product_view.xml
file that removes the main title for the product as Purenet/Client.
<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
<body>
<referenceBlock name="page.main.title" remove="true"/>
</body>
</page>
- Deploy static content for the 'Purenet Client' theme:
- bin/magento setup:static:deploy --theme="Purenet/Client" en_GB
- Apply the 'Purenet Client' theme to a category via Products > Catalog > Actual Product > Schedule Design Update > Set Dates & New theme to be Purenet/Client. Save Product.
Expected result
When checking the the product page, you should not see the main product title.
Actual result
On the Product Page, the main product title is displayed.
Setting a similar XML layout file on a category in the same manner appears to work.
Investigation
So far, it looks like _fetchPackageLayoutUpdates
within lib/internal/Magento/Framework/View/Model/Layout/Merge.php
doesn't capture the XML that contains the handle updates. I found moving the XML into catalog_product_prices
made it added as an update, however, it was still not removed.