Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML tags in meta description #14436

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

vseager
Copy link
Contributor

@vseager vseager commented Mar 29, 2018

Description

Fixes issue with HTML tags in meta description if no meta description is provided.

Fixed Issues (if relevant)

  1. HTML tags in meta description

Manual testing scenarios

  1. Ensure a product has no meta description
  2. Visit product on frontend and view page source

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 29, 2018

CLA assistant check
All committers have signed the CLA.

@larsroettig
Copy link
Member

@vseager can you sign our Contributor License Agreement.

Best regards,

Lars

@larsroettig larsroettig self-requested a review March 29, 2018 12:53
@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-1172 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vseager thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@vseager
Copy link
Contributor Author

vseager commented Mar 29, 2018

@magento-engcom-team Thanks, I have signed the agreement.

@vseager
Copy link
Contributor Author

vseager commented Apr 3, 2018

@magento-engcom-team can you also port this fix to 2.2+

@larsroettig
Copy link
Member

@vseager you can you open a ticket for it 😄somebody will take it and port to 2.2 and 2.3

@davidwindell
Copy link
Contributor

@larsroettig please see #14529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants