Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the table when adding field to filter #14596

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

PierreLeMaguer
Copy link
Contributor

Specify the table when adding field to filter for the collection Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php

Resolve the problem #14572

Fixed Issues (if relevant)

  1. Specify the table when adding field to filter for the collection Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php #14572: Specify the table when adding field to filter for the collection Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php

Manual testing scenarios

  1. Create a class with a property Magento\Eav\Model\ResourceModel\Entity\Attribute\Option\CollectionFactory
  2. Create a collection with it and join tables like 'catalog_product_entity_int'
  3. Get items of the collection.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

 for the collection Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 9, 2018

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Apr 9, 2018
@orlangur
Copy link
Contributor

orlangur commented Apr 9, 2018

Hi @PierreLeMaguer, any contribution must be delivered into 2.2-develop first. Please rewrite this PR branch with force push or create a new one targeting 2.2-develop branch.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1251 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@PierreLeMaguer thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@PierreLeMaguer
Copy link
Contributor Author

@orlangur Ok, Sorry I didn't know. The new PR : #14599

@magento-engcom-team
Copy link
Contributor

Hi @PierreLeMaguer. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.14 release.

@PierreLeMaguer PierreLeMaguer deleted the 2.1-develop branch April 11, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants