Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache count() results for loops #15507

Merged
merged 1 commit into from Aug 9, 2018
Merged

fix: cache count() results for loops #15507

merged 1 commit into from Aug 9, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 24, 2018 •
edited

Description

This improves the performance of a few loops which were runningcount() in every iteration.

Fixed Issues (if relevant)

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 25, 2018
@sidolov sidolov modified the milestones: Release: 2.2.5, Release: 2.2.6 Jun 7, 2018
@magento-engcom-team magento-engcom-team merged commit f39e3fd into magento:2.2-develop Aug 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 9, 2018
@sidolov
ENGCOM-1666: fix: cache count() results for loops #15507
78c5087
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@sreichel sreichel mentioned this pull request Aug 10, 2018
Closed
4 tasks
@gelanivishal gelanivishal mentioned this pull request Aug 11, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Component: Framework/App Component: Framework/Archive Component: Framework/Cache Component: Framework/Filter Component: Framework/System Component: Paypal Component: Setup Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielRuf @magento-engcom-team @sidolov