Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct return type of methods and typo correction #16547

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Correct return type of methods and typo correction #16547

merged 3 commits into from
Jul 5, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jul 5, 2018 •
edited by sidolov
Loading

Original Pull Request

#15993

Description

Correct return type of methods and change return type.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 5, 2018
@magento-engcom-team magento-engcom-team merged commit 0040a1c into magento:2.1-develop Jul 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 5, 2018
ENGCOM-2190: Correct return type of methods and typo correction #16547
b239212
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Cleanup Component: CatalogRule Component: CatalogSearch Component: UrlRewrite Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@gelanivishal @magento-engcom-team @sidolov @orlangur