Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Customer group extension attributes not carried over on save #16666

Merged
merged 7 commits into from
Jul 20, 2018
Merged

[Forwardport] Customer group extension attributes not carried over on save #16666

merged 7 commits into from
Jul 20, 2018

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#16254

Description

When saving a customer group, extension attributes should be copied to the new data model that is returned. Unfortunately, this action was not completed and results in unexpected behavior.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Ensure that saving a customer group does not throw any errors.
  2. Ensure that utilizing extension attributes for a customer group now carries over through the save process.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2269 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 3c632b5 into magento:2.3-develop Jul 20, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@mageprince mageprince deleted the 2.3-develop-PR-port-16254 branch July 20, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants