Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hasrequired notice for create account form and password forg… #16965

Merged
merged 1 commit into from Jul 23, 2018

Conversation

DanielRuf
Copy link
Contributor

…et form

Description

Currently the forms for "create account" and "password forget" do not have the notice for the required fields. This PR adds it.

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios

  1. go to /customer/account/create/ and /customer/account/forgotpassword/

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@ihor-sviziev ihor-sviziev self-assigned this Jul 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-16965-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ihor-sviziev
Copy link
Contributor

Manually tested, looks good.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2443 has been created to process this Pull Request

@magento magento deleted a comment from magento-engcom-team Jul 20, 2018
@magento magento deleted a comment from magento-engcom-team Jul 20, 2018
@magento magento deleted a comment from magento-engcom-team Jul 20, 2018
@magento magento deleted a comment from magento-engcom-team Jul 20, 2018
@magento magento deleted a comment from magento-engcom-team Jul 20, 2018
@magento-engcom-team magento-engcom-team merged commit 3e88d92 into magento:2.2-develop Jul 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants