-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add hasrequired notice for create account form and password forg… #16965
Conversation
Hi @DanielRuf. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me 2.2-develop instance |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.2-develop instance for you |
Hi @ihor-sviziev, here is your Magento instance. |
Manually tested, looks good. |
Hi @ihor-sviziev, thank you for the review. |
Hi @DanielRuf. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
…et form
Description
Currently the forms for "create account" and "password forget" do not have the notice for the required fields. This PR adds it.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist